Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force to unittest of JIT #326

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Add force to unittest of JIT #326

merged 1 commit into from
Oct 9, 2019

Conversation

zasdfgbnm
Copy link
Contributor

@zasdfgbnm zasdfgbnm commented Oct 9, 2019

JIT uses symbolic differentiation (autodiff), which is different from autograd. Autodiff might be buggy, we need to make sure no bugs in autodiff influence TorchANI.

Copy link
Member

@farhadrgh farhadrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhadrgh farhadrgh merged commit 273c9fd into master Oct 9, 2019
@farhadrgh farhadrgh deleted the jit-force branch October 9, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants