Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring new_zeros back #353

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Bring new_zeros back #353

merged 2 commits into from
Nov 5, 2019

Conversation

zasdfgbnm
Copy link
Contributor

Fixes #181
new_zeros seems to be already supported in JIT

@zasdfgbnm
Copy link
Contributor Author

Added in pytorch/pytorch#26511

@zasdfgbnm zasdfgbnm closed this Nov 5, 2019
@zasdfgbnm zasdfgbnm reopened this Nov 5, 2019
@zasdfgbnm
Copy link
Contributor Author

zasdfgbnm commented Nov 5, 2019

@farhadrgh test_ignite fails but it is not required anymore. So we could merge this separately.

Copy link
Member

@farhadrgh farhadrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhadrgh farhadrgh merged commit f12a27b into master Nov 5, 2019
@farhadrgh farhadrgh deleted the new_xxx branch November 5, 2019 15:00
@zubatyuk
Copy link
Contributor

This breaks JIT compatibility with pytorch-1.3.1

RuntimeError:
Unknown builtin op: aten::new_zeros.
Could not find any similar ops to aten::new_zeros. This op may not exist or may not be currently supported in TorchScript.

@zasdfgbnm
Copy link
Contributor Author

@zubatyuk Yes, correct, but we always ask the users to use the latest nightly torch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tensor.new_full and tensor.new_zeros in JIT and cleanup
3 participants