Removing ignite #354
Merged
Removing ignite #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@farhadrgh Do you think it is OK to remove the cache-aev example? I also have a feeling that AEV caching should be implemented by the user, not inside TorchANI. I don't think it is easier for a user to learn our API than to write their own AEV cache. |
zasdfgbnm
commented
Nov 5, 2019
| @@ -1,84 +0,0 @@ | |||
| import os | |||
There was a problem hiding this comment.
I already forget what this file is used for, but I don't think it is useful anymore.
farhadrgh
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been lots of high-level libraries for PyTorch coming with time. Ignite is not the only one. I guess users of these libraries should create wrappers by themselves for these high-level libraries, instead of we maintaining these wrappers.