Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type inference of arange to clean up code #357

Merged
merged 10 commits into from
Nov 12, 2019
Merged

Use type inference of arange to clean up code #357

merged 10 commits into from
Nov 12, 2019

Conversation

zasdfgbnm
Copy link
Contributor

Fixes #182

This PR doesn't work right now due to PyTorch bug. Keep an eye on pytorch/pytorch#27629, when it gets merged, this PR could be merged.

@farhadrgh farhadrgh added the Waiting for PyTorch Waiting for an issue or PR to be resolved in PyTorch label Nov 5, 2019
@zasdfgbnm zasdfgbnm mentioned this pull request Nov 8, 2019
@zasdfgbnm
Copy link
Contributor Author

The PyTorch PR has been merged. Waiting for one day.

@zasdfgbnm
Copy link
Contributor Author

@farhadrgh This is working now!

Copy link
Member

@farhadrgh farhadrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhadrgh farhadrgh merged commit c41581a into master Nov 12, 2019
@farhadrgh farhadrgh deleted the arange branch November 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for PyTorch Waiting for an issue or PR to be resolved in PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dtype of arange in JIT and remove dtype of arange from TorchANI
2 participants