Use modern type annotations for models.py #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 25f1d9b into ae2497d - view on LGTM.com new alerts:
|
farhadrgh
approved these changes
Nov 7, 2019
zasdfgbnm
added a commit
that referenced
this pull request
Nov 7, 2019
* Remove python2 support from CI, _six, etc. (#370) * Remove python2 step 1 * badge * Delete _six.py * Simplify triple_by_molecule (#368) * Simplify triple_by_molecule * fix * fix * fix * Use @ syntax (#371) * Use modern type annotations for nn.py (#373) * Use modern type annotations for nn.py * flake8 * Use modern type annotations for models.py (#374)
farhadrgh
pushed a commit
that referenced
this pull request
Nov 7, 2019
* Use modern type annotations for utils.py * update (#377) * Remove python2 support from CI, _six, etc. (#370) * Remove python2 step 1 * badge * Delete _six.py * Simplify triple_by_molecule (#368) * Simplify triple_by_molecule * fix * fix * fix * Use @ syntax (#371) * Use modern type annotations for nn.py (#373) * Use modern type annotations for nn.py * flake8 * Use modern type annotations for models.py (#374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying type inside a comment is stupid and should be removed