Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jit hessian #397

Merged
merged 6 commits into from
Nov 22, 2019
Merged

Support jit hessian #397

merged 6 commits into from
Nov 22, 2019

Conversation

zasdfgbnm
Copy link
Contributor

Not working yet, something must be done in PyTorch first to add support of retain_graph.

@zasdfgbnm zasdfgbnm changed the title Support jit hessian [WIP] Support jit hessian Nov 20, 2019
@zasdfgbnm
Copy link
Contributor Author

PyTorch bug fixed in pytorch/pytorch#30203

@zasdfgbnm zasdfgbnm changed the title [WIP] Support jit hessian Support jit hessian Nov 21, 2019
@farhadrgh farhadrgh added the Waiting for PyTorch Waiting for an issue or PR to be resolved in PyTorch label Nov 21, 2019
@zasdfgbnm
Copy link
Contributor Author

@farhadrgh Ready

Copy link
Member

@farhadrgh farhadrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhadrgh farhadrgh merged commit 9833dd6 into master Nov 22, 2019
@farhadrgh farhadrgh deleted the jit-hessian branch November 22, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for PyTorch Waiting for an issue or PR to be resolved in PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants