Add possibility to use custom padding (address issue #458) #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnacioJPickering
requested review from
farhadrgh,
yueyericardo and
zasdfgbnm
as code owners
IgnacioJPickering
changed the title
IgnacioJPickering
changed the title
zasdfgbnm
reviewed
Jun 17, 2020
torchani/data/__init__.py
Outdated
| @@ -35,7 +35,11 @@ | |||
| - `shuffle` | |||
| - `cache` cache the result of previous transformations. | |||
| - `collate` pad the dataset, convert it to tensor, and stack them | |||
| together to get a batch. | |||
| together to get a batch. Collat uses a default padding dictionary | |||
zasdfgbnm
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional argument to collate_fn to add to address @plin1112 issue #458 and adds that to the documentation.