Fix gradcheck test #493
Merged
Fix gradcheck test #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new tests, testGradCheck and testGradGradCheck, which are done in a way that
are actually feasible in CPU and CUDA (tests take in total ~4 s in CPU). Currently these tests pass.
This PR deletes testGradient which was essentially never run since it was skipped by github and also always failed.
The issue was nondet_tol which was set to zero but shouldn't be, since many pytorch operations we perform use atomic_add and
similar nondeterministic ops internally, which means two inputs have very slightly different outputs. Also this test was incredibly slow.