BUGFIX: Log version validation errors with ID from record #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran your bug report and got this error: /Users/batkins/.rvm/gems/ruby-2.3.1@paper_trail/gems/sqlite3-1.3.10/lib/sqlite3/database.rb:91:in `initialize': SQLite3::SQLException: table versions has no column named transaction_id: CREATE INDEX "index_versions_on_transaction_id" ON "versions" ("transaction_id") (ActiveRecord::StatementInvalid)After commenting out the offending line, I re-ran it, and got the error you're reporting. Good catch here and the fix looks like it's spot on. Thanks for the PR! |
|
Thanks Owen. This one's probably my fault from #719 |
batter
added a commit
that referenced
this pull request
Nov 26, 2016
batter
added a commit
that referenced
this pull request
Nov 26, 2016
batter
added a commit
that referenced
this pull request
Nov 29, 2016
BUGFIX: Log version validation errors with ID from record
batter
added a commit
that referenced
this pull request
Nov 29, 2016
aried3r
pushed a commit
to aried3r/paper_trail
that referenced
this pull request
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a case where the logging of errors in PaperTrail is causing an exception (and hiding the underlying issue). I have a convoluted example in the usual bug report format and a fix attached. No tests provided since I am unsure how to reproduce this without doing something complex or unusual.