Skip to content

Commit

Permalink
Update CHANGELOG regarding #889
Browse files Browse the repository at this point in the history
  • Loading branch information
batter committed Nov 29, 2016
1 parent ccaa291 commit 087533e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 4 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ recommendations of [keepachangelog.com](http://keepachangelog.com/).

### Fixed

- [#889](https://github.com/airblade/paper_trail/pull/889) -
Fix warning message in instances when a version can't be persisted due to validation errors.
- [#868](https://github.com/airblade/paper_trail/pull/868)
Fix usage of find_by_id when primary key is not id, affecting reifying certain records.

Expand All @@ -30,7 +32,7 @@ recommendations of [keepachangelog.com](http://keepachangelog.com/).

### Deprecated

- [#863](https://github.com/airblade/paper_trail/pull/863)
- [#863](https://github.com/airblade/paper_trail/pull/863) -
PaperTrail.timestamp_field= deprecated without replacement.
See [#861](https://github.com/airblade/paper_trail/pull/861) for discussion.

Expand Down Expand Up @@ -407,7 +409,7 @@ candidates.
## 3.0.5

- [#401](https://github.com/airblade/paper_trail/issues/401) / [#406](https://github.com/airblade/paper_trail/issues/406) -
`PaperTrail::Version` class is not loaded via a `Rails::Engine`, even when the gem is used with in Rails. This feature has
`PaperTrail::Version` class is not loaded via a `Rails::Engine`, even when the gem is used within Rails. This feature has
will be re-introduced in version `4.0`.
- [#398](https://github.com/airblade/paper_trail/pull/398) - Only require the `RSpec` helper if `RSpec::Core` is required.

Expand Down
5 changes: 2 additions & 3 deletions lib/paper_trail/record_trail.rb
Original file line number Diff line number Diff line change
Expand Up @@ -418,9 +418,8 @@ def add_transaction_id_to(data)

def log_version_errors(version, action)
version.logger.warn(
"Unable to create version for #{action} of #{@record.class.name}#" +
"#{@record.id}: " +
version.errors.full_messages.join(", ")
"Unable to create version for #{action} of #{@record.class.name}" +
"##{@record.id}: " + version.errors.full_messages.join(", ")
)
end

Expand Down

0 comments on commit 087533e

Please sign in to comment.