Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS support #81

Merged
merged 27 commits into from
Jul 30, 2020
Merged

tvOS support #81

merged 27 commits into from
Jul 30, 2020

Conversation

RomanPodymov
Copy link
Contributor

Hello.
Thank you for MagazineLayout.
In this pull request I added tvOS support.

Details

Added appletvos and appletvsimulator platforms for MagazineLayout.framework.
Added MagazineLayoutExampleAppleTV to test MagazineLayout.framework on tvOS.
Using #if os(iOS) for the iOS-only classes.

Related Issue

Motivation and Context

I think it will be nice to have tvOS support for MagazineLayout.

How Has This Been Tested

I launched MagazineLayoutExampleAppleTV on Apple TV 4K simulator with tvOS 13.4.
I observed the same collection views as in MagazineLayoutExample.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@bryankeller bryankeller self-requested a review July 24, 2020 05:33
@bryankeller bryankeller added the enhancement New feature or request label Jul 24, 2020
@bryankeller
Copy link
Contributor

bryankeller commented Jul 24, 2020

Thanks @RomanPodymov ! If you can get the build working, then this seems like a good change! https://travis-ci.com/github/airbnb/MagazineLayout/builds/176573279

@RomanPodymov
Copy link
Contributor Author

Thanks @RomanPodymov ! If you can get the build working, then this seems like a good change! https://travis-ci.com/github/airbnb/MagazineLayout/builds/176573279

Done.

@bryankeller
Copy link
Contributor

thanks a bunch @RomanPodymov !

@bryankeller bryankeller merged commit 341620e into airbnb:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants