Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Showkase to latest version of Jetpack Compose Navigation #370

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

designedbyz
Copy link

This PR updates the version of Jetpack Compose navigation to the latest version, 2.7.6, and updates other dependencies as needed along the way as well. This is needed to avoid some odd behavior with navigation 2.6.0; notably if you use compose navigation 2.6.0 and Showkase in the same project, the browser will not navigate from the root screen to any of typography, color, or composables. This seems to be an issue with Navigation 2.6.0, as both navigation 2.7.x and navigation 2.5.x work just fine.

Other dependencies have been updated as needed as well, most notably perhaps was updating the compile SDK to version 34. This was required for navigation 2.7.x.

I've seen a few issues while running tests on the project that I could use some help solving. Specifically, the entering_text_in_search_bar_filters_the_visible_components and entering_text_in_search_bar_filters_the_visible_groups_of_components are acting a bit weird detecting two nodes, even though I only see one visible node when debugging the tests. I'd appreciate some help with debugging this.

@vinaygaba
Copy link
Collaborator

@designedbyz Genuinely grateful for your contribution. I wrote the browser piece of Showkase in 2020 when there was little to no documentation about Compose so there were a bunch of bad practices that I wanted to fix holistically. For example, there was no framework level solution to go back even 😅 I'm attempting to fix all that + the navigation dependencies in this PR - #390 🤞

Would it be okay if I closed this PR as a lot needed to change for some of the bugs that I was observing to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants