Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd link to es5 and es6 compat table in readme #2850

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

matheusfelipeog
Copy link
Contributor

The old links are dead. The current link base path for compat table (https://kangax.github.io/compat-table/) is redirecting to https://compat-table.github.io/compat-table/

@ljharb
Copy link
Collaborator

ljharb commented Oct 13, 2023

They’re not dead, because they redirect, but thanks.

@matheusfelipeog
Copy link
Contributor Author

They’re not dead, because they redirect, but thanks.

Sorry @ljharb, I'm referring to the paths */es5/ and */es6/:

https://kangax.github.io/compat-table/es5/
image

https://kangax.github.io/compat-table/es6/
image

@ljharb
Copy link
Collaborator

ljharb commented Oct 13, 2023

ah, thanks; I’ll fix those to redirect properly.

@ljharb
Copy link
Collaborator

ljharb commented Oct 13, 2023

kangax/kangax.github.com#3 will fix the redirects, but we should still change all the "kangax" to "compat-table".

@matheusfelipeog
Copy link
Contributor Author

Good job @ljharb, thanks.

I'm going to change all "kangax" to "compat-table" now to comply

@matheusfelipeog
Copy link
Contributor Author

Okay, apparently that was the only mention left.

@ljharb ljharb force-pushed the docs/upd-compat-table-links branch from c40d6f9 to 6499695 Compare October 5, 2024 06:45
@ljharb ljharb merged commit 6499695 into airbnb:master Oct 5, 2024
47 checks passed
@matheusfelipeog matheusfelipeog deleted the docs/upd-compat-table-links branch October 7, 2024 19:07
@matheusfelipeog
Copy link
Contributor Author

Tks @ljharb 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants