Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GroupNode empty transform issue (#1372) #1510

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Fixed GroupNode empty transform issue (#1372) #1510

merged 1 commit into from
Feb 1, 2022

Conversation

calda
Copy link
Member

@calda calda commented Feb 1, 2022

This PR integrates @sroik's changes from #1372 (I tried to rebase that PR manually but messed up, classic mistake)

1 was incorrect here -- these values are actually percentages, so 1 meant "1%"

Default empty transform should match `ShapeTransform.swift`default empty state
Copy link
Collaborator

@erichoracek erichoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calda calda merged commit 3cfde67 into master Feb 1, 2022
@calda calda deleted the cal--1372 branch February 1, 2022 21:39
calda added a commit that referenced this pull request Nov 28, 2022
Default empty transform should match `ShapeTransform.swift`default empty state

Co-authored-by: sroik <[email protected]>
calda added a commit that referenced this pull request Dec 1, 2022
Default empty transform should match `ShapeTransform.swift`default empty state

Co-authored-by: sroik <[email protected]>
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Default empty transform should match `ShapeTransform.swift`default empty state

Co-authored-by: sroik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants