-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blend mode support #1585
Blend mode support #1585
Conversation
Thanks for the contribution @k-o-d-e-n! I'm going to convert this to a draft for now since CI isn't passing, but feel free to continue working on this. Once CI passes, I think we can merge this.
|
@k-o-d-e-n, some of the checks are failing. I think you need to:
|
If the snapshot test case keeps failing, then the rendered output must be slightly nondeterministic. You an work around this type of issue by decreasing the comparison precision (example: https://github.com/airbnb/lottie-ios/blob/master/Tests/SnapshotConfiguration.swift#L43) |
I pushed some commits that address the CI failures.
Will merge once checks pass. Thanks again for your contribution! |
Thanks for help! |
Co-authored-by: Cal Stephens <[email protected]>
Co-authored-by: Cal Stephens <[email protected]>
Co-authored-by: Cal Stephens <[email protected]>
No description provided.