deps: Audit 2020-03-24 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 24, 2020 12:03
milesj
requested review from
alecklandgraf,
hayes and
stefhatcher
as code owners
milesj
commented
Mar 24, 2020
| @@ -27,6 +27,9 @@ module.exports = { | |||
| 'import/no-extraneous-dependencies': 'off', | |||
| 'jest/require-to-throw-message': 'off', // Prop type errors | |||
| 'react/jsx-no-literals': 'off', | |||
| '@typescript-eslint/no-unsafe-call': 'off', | |||
There was a problem hiding this comment.
Only for tests/stories.
milesj
commented
Mar 24, 2020
| @@ -82,7 +82,7 @@ export function executeAGraphQlMutationAndHandleTheResponseWhenReceived() { | |||
| return ( | |||
| <MockedProvider mocks={[mock]} addTypename={false}> | |||
| <Mutation mutation={MUTATION} variables={variables}> | |||
| {updateUser => <UpdateButton onUpdate={updateUser} />} | |||
| {(updateUser) => <UpdateButton onUpdate={updateUser} />} | |||
There was a problem hiding this comment.
All parens are prettier changes.
stefhatcher
approved these changes
Mar 24, 2020
added 2 commits
March 24, 2020 17:00
Size Changes
View raw build statsPrevious (master){
"apollo": {
"esm": 10741,
"lib": 14056
},
"app-shell": {
"esm": 12763,
"lib": 19731
},
"composer": {
"esm": 66717,
"lib": 100275
},
"core": {
"esm": 550554,
"lib": 694370
},
"forms": {
"esm": 35025,
"lib": 46930
},
"icons": {
"esm": 148490,
"lib": 197179
},
"layouts": {
"esm": 14973,
"lib": 20445
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4137,
"lib": 5795
}
}Current{
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68122,
"lib": 101680
},
"core": {
"esm": 559543,
"lib": 702408
},
"forms": {
"esm": 35672,
"lib": 47577
},
"icons": {
"esm": 153001,
"lib": 201690
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @milesj @stefhatcher @hayes @alecklandgraf
Description
It's a been a while. Biggest change is the Nimbus update. airbnb/nimbus#29
Motivation and Context
Mainly updates Aesthetic to fix some SSR issues.
Testing
Unit tests and storybook.
Screenshots
Checklist