New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Autocomplete): isItemSelected should check against input value #405

Closed

ktmud wants to merge 1 commit into airbnb:master from ktmud:bugfix--autocomplete-isItemSelected

ktmud commented Oct 23, 2020

to: @williaster @alecklandgraf

Description

This is an obvious bug.

Motivation and Context

Testing

TODO

Screenshots

Checklist

My code follows the style guide of this project.
I have updated or added documentation accordingly.
I have read the CONTRIBUTING document.


          fix(Autocomplete): isItemSelected should check against input value

a63db89

Contributor

williaster commented Oct 23, 2020

Hey @ktmud sorry PRs to Lunar can't be forks because CI can't run on forks. So will have to push a branch to master (let me know if you have issues)

Author

ktmud commented Oct 23, 2020

Thanks for the reminder, @williaster ! Recreated #406

ktmud closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

williaster Awaiting requested review from williaster williaster will be requested when the pull request is marked ready for review williaster is a code owner

alecklandgraf Awaiting requested review from alecklandgraf alecklandgraf will be requested when the pull request is marked ready for review alecklandgraf is a code owner

Labels

None yet