Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add innerRef prop to ScaleSVG in @vx/responsive #393

Merged
merged 1 commit into from
Jan 4, 2019
Merged

add innerRef prop to ScaleSVG in @vx/responsive #393

merged 1 commit into from
Jan 4, 2019

Conversation

dagda1
Copy link

@dagda1 dagda1 commented Dec 23, 2018 •
edited
Loading

🚀 Enhancements

add the ability to add a ref to ScaleSVG

I currently need a ref in the svg rendered from ScaleSVG.

<svg
  preserveAspectRatio={preserveAspectRatio}
  viewBox={`${xOrigin} ${yOrigin} ${width} ${height}`}
  ref={innerRef}
>
  {children}
</svg>

@hshoff hshoff added this to the v0.0.183 milestone Jan 4, 2019
@hshoff hshoff merged commit 1c3cb99 into airbnb:master Jan 4, 2019
@hshoff hshoff mentioned this pull request Jan 4, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.183
Development

Successfully merging this pull request may close these issues.
2 participants
@dagda1 @hshoff