Skip to content

Commit

Permalink
remove dependency declared twice (#21628)
Browse files Browse the repository at this point in the history
* remove dependency declared twice

* remove dependency declared twice
  • Loading branch information
colesnodgrass authored Jan 20, 2023
1 parent 8a95c5c commit 1b52c30
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ dependencies {
implementation project(':airbyte-json-validation')
implementation project(':airbyte-integrations:bases:base-java')
implementation project(':airbyte-protocol:protocol-models')
implementation project(':airbyte-commons-worker')

implementation(enforcedPlatform('org.junit:junit-bom:5.8.2'))
implementation 'org.junit.jupiter:junit-jupiter-api'
Expand Down
12 changes: 6 additions & 6 deletions airbyte-integrations/bases/standard-source-test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ dependencies {
implementation project(':airbyte-config:config-models')
implementation project(':airbyte-config:config-persistence')
implementation project(':airbyte-protocol:protocol-models')
implementation project(':airbyte-commons-worker')
implementation 'org.mockito:mockito-core:4.6.1'

implementation 'net.sourceforge.argparse4j:argparse4j:0.8.1'
Expand All @@ -30,7 +29,7 @@ dependencies {

def getFullPath(String className) {
def matchingFiles = project.fileTree("src/main/java")
.filter { file -> file.getName().equals("${className}.java".toString())}.asCollection()
.filter { file -> file.getName().equals("${className}.java".toString()) }.asCollection()
if (matchingFiles.size() == 0) {
throw new IllegalArgumentException("Ambiguous class name ${className}: no file found.")
}
Expand All @@ -51,14 +50,15 @@ task generateSourceTestDocs(type: Javadoc) {
destinationDir = javadocOutputDir

doLast {
def className = "SourceAcceptanceTest" // this can be made into a list once we have multiple standard tests, and can also be used for destinations
def className = "SourceAcceptanceTest"
// this can be made into a list once we have multiple standard tests, and can also be used for destinations
def pathInPackage = getFullPath(className)
def stdSrcTest = project.file("${javadocOutputDir}/${pathInPackage}.html").readLines().join("\n")
def methodList = Jsoup.parse(stdSrcTest).body().select("section.methodDetails>ul>li>section")
def md = ""
for (methodInfo in methodList){
for (methodInfo in methodList) {
def annotations = methodInfo.select(".memberSignature>.annotations").text()
if (!annotations.contains("@Test")){
if (!annotations.contains("@Test")) {
continue
}
def methodName = methodInfo.selectFirst("div>span.memberName").text()
Expand All @@ -73,7 +73,7 @@ task generateSourceTestDocs(type: Javadoc) {
outputDoc.append md
}

outputs.upToDateWhen {false}
outputs.upToDateWhen { false }
}

project.build.dependsOn(generateSourceTestDocs)
Expand Down

0 comments on commit 1b52c30

Please sign in to comment.