Skip to content

Commit

Permalink
Move the port forward outside of the main docker-compose (#17864)
Browse files Browse the repository at this point in the history
  • Loading branch information
benmoriceau authored Oct 17, 2022
1 parent 8560f19 commit 260ab6b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
13 changes: 13 additions & 0 deletions docker-compose.acceptance-test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Adds ports to the db and access to the temporal UI for debugging purposes.
# Expected to be used like this:
# VERSION=dev docker-compose -f docker-compose.yaml -f docker-compose.debug.yaml up
version: "3.7"
x-logging: &default-logging
options:
max-size: "100m"
max-file: "5"
driver: json-file
services:
airbyte-temporal:
ports:
- 7233:7233
2 changes: 0 additions & 2 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,6 @@ services:
logging: *default-logging
container_name: airbyte-temporal
restart: unless-stopped
ports:
- 7233:7233
environment:
- DB=postgresql
- DB_PORT=${DATABASE_PORT}
Expand Down
2 changes: 1 addition & 1 deletion tools/bin/acceptance_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ check_success() {
echo "Starting app..."

# Detach so we can run subsequent commands
VERSION=dev TRACKING_STRATEGY=logging USE_STREAM_CAPABLE_STATE=true docker-compose up -d
VERSION=dev TRACKING_STRATEGY=logging USE_STREAM_CAPABLE_STATE=true docker-compose -f docker-compose.yaml -f docker-compose.acceptance-test.yaml up -d

# Sometimes source/dest containers using airbyte volumes survive shutdown, which need to be killed in order to shut down properly.
shutdown_cmd="docker-compose down -v || docker kill \$(docker ps -a -f volume=airbyte_workspace -f volume=airbyte_data -f volume=airbyte_db -q) && docker-compose down -v"
Expand Down

0 comments on commit 260ab6b

Please sign in to comment.