Skip to content

Commit

Permalink
🪟 🧹 Remove <StartWithDestination /> Component (#20943)
Browse files Browse the repository at this point in the history
Removing code related to this experiment as it didn't have any impact
  • Loading branch information
letiescanciano authored Jan 4, 2023
1 parent 5f55f25 commit 2a83aec
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 244 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ import { useGetDestinationDefinitionSpecificationAsync } from "services/connecto
import { ConnectorIds } from "utils/connectors";
import { FormError } from "utils/errorStatusMessage";
import { ConnectorCard } from "views/Connector/ConnectorCard";
import { ConnectorCardValues, FrequentlyUsedConnectors, StartWithDestination } from "views/Connector/ConnectorForm";

import styles from "./DestinationForm.module.scss";
import { ConnectorCardValues, FrequentlyUsedConnectors } from "views/Connector/ConnectorForm";

interface DestinationFormProps {
onSubmit: (values: {
Expand Down Expand Up @@ -69,29 +67,21 @@ export const DestinationForm: React.FC<DestinationFormProps> = ({ onSubmit, dest
connectorIds={frequentlyUsedDestinationIds}
/>
);
const startWithDestinationComponent = !isLoading && !destinationDefinitionId && (
<div className={styles.startWithDestinationContainer}>
<StartWithDestination onDestinationSelect={onDropDownSelect} availableServices={destinationDefinitions} />
</div>
);

return (
<>
<ConnectorCard
formType="destination"
title={<FormattedMessage id="onboarding.destinationSetUp" />}
description={<FormattedMessage id="destinations.description" />}
isLoading={isLoading}
fetchingConnectorError={destinationDefinitionError instanceof Error ? destinationDefinitionError : null}
availableConnectorDefinitions={destinationDefinitions}
onConnectorDefinitionSelect={onDropDownSelect}
selectedConnectorDefinitionSpecification={destinationDefinitionSpecification}
selectedConnectorDefinitionId={destinationDefinitionId}
onSubmit={onSubmitForm}
jobInfo={LogsRequestError.extractJobInfo(error)}
additionalSelectorComponent={frequentlyUsedDestinationsComponent}
/>
{startWithDestinationComponent}
</>
<ConnectorCard
formType="destination"
title={<FormattedMessage id="onboarding.destinationSetUp" />}
description={<FormattedMessage id="destinations.description" />}
isLoading={isLoading}
fetchingConnectorError={destinationDefinitionError instanceof Error ? destinationDefinitionError : null}
availableConnectorDefinitions={destinationDefinitions}
onConnectorDefinitionSelect={onDropDownSelect}
selectedConnectorDefinitionSpecification={destinationDefinitionSpecification}
selectedConnectorDefinitionId={destinationDefinitionId}
onSubmit={onSubmitForm}
jobInfo={LogsRequestError.extractJobInfo(error)}
additionalSelectorComponent={frequentlyUsedDestinationsComponent}
/>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ export interface Experiments {
"connector.inviteUsersHint.linkToUsersPage": boolean;
"connector.orderOverwrite": Record<string, number>;
"connector.frequentlyUsedDestinationIds": string[];
"connector.startWithDestinationId": string;
"connector.form.useDatepicker": boolean;
"authPage.rightSideUrl": string | undefined;
"authPage.hideSelfHostedCTA": boolean;
Expand Down
2 changes: 0 additions & 2 deletions airbyte-webapp/src/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,6 @@
"destinations.newDestinationTitle": "New destination",
"destinations.destinationSetUp": "Set up the destination",
"destinations.frequentlyUsed": "Most frequently used destinations",
"destinations.dontHaveYourOwnDestination": "Don’t have your own destination yet?",
"destinations.startWith": "Start with {name}",

"connection.stream.syncMode": "{syncMode} - {destinationSyncMode}",

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion airbyte-webapp/src/views/Connector/ConnectorForm/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export * from "./types";
export * from "./ConnectorForm";

export { StartWithDestination } from "./components/StartWithDestination";
export { FrequentlyUsedConnectors } from "./components/FrequentlyUsedConnectors";

0 comments on commit 2a83aec

Please sign in to comment.