remove loadData

airbytehq · Nov 1, 2022 · 2e6407c · 2e6407c
1 parent 3719424
commit 2e6407c
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 177 deletions.
diff --git a/...sistence/src/main/java/io/airbyte/config/persistence/ClassEnforcingConfigPersistence.java b/...sistence/src/main/java/io/airbyte/config/persistence/ClassEnforcingConfigPersistence.java
@@ -91,9 +91,4 @@ public Map<String, Stream<JsonNode>> dumpConfigs() throws IOException {
     return decoratedPersistence.dumpConfigs();
   }
 
-  @Override
-  public void loadData(final ConfigPersistence seedPersistence) throws IOException {
-    decoratedPersistence.loadData(seedPersistence);
-  }
-
 }
diff --git a/...fig/config-persistence/src/main/java/io/airbyte/config/persistence/ConfigPersistence.java b/...fig/config-persistence/src/main/java/io/airbyte/config/persistence/ConfigPersistence.java
@@ -38,6 +38,4 @@ <T> ConfigWithMetadata<T> getConfigWithMetadata(AirbyteConfig configType, String
 
   Map<String, Stream<JsonNode>> dumpConfigs() throws IOException;
 
-  void loadData(ConfigPersistence seedPersistence) throws IOException;
-
 }
diff --git a/...ig-persistence/src/main/java/io/airbyte/config/persistence/DatabaseConfigPersistence.java b/...ig-persistence/src/main/java/io/airbyte/config/persistence/DatabaseConfigPersistence.java
@@ -1638,14 +1638,6 @@ public Map<String, Stream<JsonNode>> dumpConfigs() throws IOException {
     return result;
   }
 
-  @Override
-  public void loadData(final ConfigPersistence seedConfigPersistence) throws IOException {
-    database.transaction(ctx -> {
-      updateConfigsFromSeed(ctx, seedConfigPersistence);
-      return null;
-    });
-  }
-
   @VisibleForTesting
   void updateConfigsFromSeed(final DSLContext ctx, final ConfigPersistence seedConfigPersistence) throws SQLException {
     LOGGER.info("Updating connector definitions from the seed if necessary...");
@@ -1940,8 +1932,8 @@ static class ConnectorInfo {
     ConnectorInfo(final String definitionId, final JsonNode definition) {
       this.definitionId = definitionId;
       this.definition = definition;
-      this.dockerRepository = definition.get("dockerRepository").asText();
-      this.dockerImageTag = definition.get("dockerImageTag").asText();
+      dockerRepository = definition.get("dockerRepository").asText();
+      dockerImageTag = definition.get("dockerImageTag").asText();
     }
 
     @Override

diff --git a/...-persistence/src/main/java/io/airbyte/config/persistence/ValidatingConfigPersistence.java b/...-persistence/src/main/java/io/airbyte/config/persistence/ValidatingConfigPersistence.java
@@ -115,11 +115,6 @@ public Map<String, Stream<JsonNode>> dumpConfigs() throws IOException {
     return decoratedPersistence.dumpConfigs();
   }
 
-  @Override
-  public void loadData(final ConfigPersistence seedPersistence) throws IOException {
-    decoratedPersistence.loadData(seedPersistence);
-  }
-
   private <T> void validateJson(final T config, final AirbyteConfig configType) throws JsonValidationException {
     final JsonNode schema = JsonSchemaValidator.getSchema(configType.getConfigSchemaFile());
     schemaValidator.ensure(schema, Jsons.jsonNode(config));

diff --git a/...ce/src/test/java/io/airbyte/config/persistence/DatabaseConfigPersistenceLoadDataTest.java b/...ce/src/test/java/io/airbyte/config/persistence/DatabaseConfigPersistenceLoadDataTest.java