Skip to content

Commit

Permalink
should have workspaceid for update connection (#22512)
Browse files Browse the repository at this point in the history
* should have workspaceid for update connection

* add test
  • Loading branch information
xiaohansong authored Feb 7, 2023
1 parent 85a6026 commit 6f0c0be
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ public CheckConnectionRead checkSourceConnectionFromSourceIdForUpdate(final Sour
final SourceCoreConfig sourceCoreConfig = new SourceCoreConfig()
.sourceId(updatedSource.getSourceId())
.connectionConfiguration(updatedSource.getConfiguration())
.sourceDefinitionId(updatedSource.getSourceDefinitionId());
.sourceDefinitionId(updatedSource.getSourceDefinitionId())
.workspaceId(updatedSource.getWorkspaceId());

return checkSourceConnectionFromSourceCreate(sourceCoreConfig);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,8 @@ void testCheckSourceConnectionFromUpdate() throws IOException, JsonValidationExc
final SourceConnection submittedSource = new SourceConnection()
.withSourceId(source.getSourceId())
.withSourceDefinitionId(source.getSourceDefinitionId())
.withConfiguration(source.getConfiguration());
.withConfiguration(source.getConfiguration())
.withWorkspaceId(source.getWorkspaceId());
when(synchronousSchedulerClient.createSourceCheckConnectionJob(submittedSource, DESTINATION_DOCKER_IMAGE, protocolVersion, false))
.thenReturn((SynchronousResponse<StandardCheckConnectionOutput>) jobResponse);
when(secretsRepositoryWriter.statefulSplitEphemeralSecrets(
Expand Down

0 comments on commit 6f0c0be

Please sign in to comment.