Skip to content

Commit

Permalink
version bumps
Browse files Browse the repository at this point in the history
  • Loading branch information
edgao committed May 3, 2022
1 parent da3374e commit 8aaf084
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ RUN tar xf ${APPLICATION}.tar --strip-components=1

ENV ENABLE_SENTRY true

LABEL io.airbyte.version=0.4.24
LABEL io.airbyte.version=0.4.25
LABEL io.airbyte.name=airbyte/destination-snowflake
1 change: 1 addition & 0 deletions docs/integrations/destinations/snowflake.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ Now that you have set up the Snowflake destination connector, check out the foll

| Version | Date | Pull Request | Subject |
|:--------|:-----------| :----- | :------ |
| 0.4.25 | 2022-05-03 | [\#12452](https://github.com/airbytehq/airbyte/pull/12452) | Add support for encrypted staging on S3; fix the purge_staging_files option |
| 0.4.24 | 2022-03-24 | [\#11093](https://github.com/airbytehq/airbyte/pull/11093) | Added OAuth support (Compatible with Airbyte Version 0.35.60+)|
| 0.4.22 | 2022-03-18 | [\#10793](https://github.com/airbytehq/airbyte/pull/10793) | Fix namespace with invalid characters |
| 0.4.21 | 2022-03-18 | [\#11071](https://github.com/airbytehq/airbyte/pull/11071) | Switch to compressed on-disk buffering before staging to s3/internal stage |
Expand Down

4 comments on commit 8aaf084

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Destination S3(#12452)

Measures

Name Value Name Value Name Value
Security Rating A Quality Gate Status ERROR Vulnerabilities 2
Code Smells 52 Lines to Cover 21 Duplicated Blocks 3
Reliability Rating A Duplicated Lines (%) 0.0 Lines of Code 3335
Bugs 2 Coverage 0.0 Blocker Issues 0
Critical Issues 7 Major Issues 46 Minor Issues 7

Detected Issues

Rule File Description Message
java:S6218 (MAJOR) s3/AesCbcEnvelopeEncryption.java:14 Equals method should be overridden in records containing array fields Override toString to consider array's content in the method
java:S112 (MAJOR) s3/AesCbcEnvelopeEncryption.java:39 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1135 (INFO) s3/AesCbcEnvelopeEncryptionBlobDecorator.java:55 Track uses of "TODO" tags Complete the task associated to this TODO comment.
java:S3329 (CRITICAL) s3/AesCbcEnvelopeEncryptionBlobDecorator.java:92 Cipher Block Chaining IVs should be unpredictable Use a dynamically-generated, random IV.
java:S112 (MAJOR) s3/AesCbcEnvelopeEncryptionBlobDecorator.java:95 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S5542 (CRITICAL) s3/AesCbcEnvelopeEncryptionBlobDecorator.java:106 Encryption algorithms should be used with secure mode and padding scheme Use secure mode and padding scheme.
java:S5803 (CRITICAL) s3/AesCbcEnvelopeEncryptionBlobDecorator.java:110 Class members annotated with "@VisibleForTesting" should not be accessed from production code Remove this usage of "insertMetadata", it is annotated with @VisibleForTesting and should not be accessed from production code.
java:S112 (MAJOR) s3/AesCbcEnvelopeEncryptionBlobDecorator.java:113 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/AesCbcEnvelopeEncryptionBlobDecorator.java:123 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1610 (MINOR) s3/BlobDecorator.java Abstract classes without fields should be converted to interfaces Convert the abstract class "BlobDecorator" into an interface. (sonar.java.source not set. Assuming 8 or greater.)
java:S5993 (MAJOR) s3/BlobStorageOperations.java Constructors of an "abstract" class should not be declared "public" Change the visibility of this constructor to "protected".
java:S117 (MINOR) s3/BlobStorageOperations.java Local variable and method parameter names should comply with a naming convention Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
java:S112 (MAJOR) s3/BlobStorageOperations.java:27 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/BlobStorageOperations.java:35 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/BlobStorageOperations.java:40 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) csv/CsvSerializedBuffer.java:37 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) jsonl/JsonLSerializedBuffer.java:33 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1118 (MAJOR) util/CompressionTypeHelper.java Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S112 (MAJOR) s3/S3Destination.java:83 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/S3Destination.java:97 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1155 (MINOR) s3/S3StorageOperations.java Collection.isEmpty() should be used to test for emptiness Use isEmpty() to check whether the collection is empty or not.
java:S1192 (CRITICAL) s3/S3StorageOperations.java:244 String literals should not be duplicated Define a constant instead of duplicating this literal "[0-9]{2}" 5 times.
java:S119 (MINOR) credential/BlobStorageCredentialConfig.java:7 Type parameter names should comply with a naming convention Rename this generic name to match the regular expression '^[A-Z][0-9]?$'.
java:S1172 (MAJOR) s3/S3ConsumerFactory.java:73 Unused method parameters should be removed Remove this unused method parameter "namingResolver".
java:S1611 (MINOR) s3/S3ConsumerFactory.java:152 Parentheses should be removed from a single lambda input parameter when its type is inferred Remove the parentheses around the "hasFailed" parameter (sonar.java.source not set. Assuming 8 or greater.)
java:S1118 (MAJOR) s3/SerializedBufferFactory.java:25 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S112 (MAJOR) s3/SerializedBufferFactory.java:72 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) avro/AvroSerializedBuffer.java:34 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
common-java:DuplicatedBlocks (MAJOR) avro/S3AvroWriter.java Source files should not have any duplicated blocks 1 duplicated blocks of code must be removed.
common-java:DuplicatedBlocks (MAJOR) csv/S3CsvWriter.java Source files should not have any duplicated blocks 1 duplicated blocks of code must be removed.
common-java:DuplicatedBlocks (MAJOR) jsonl/S3JsonlWriter.java Source files should not have any duplicated blocks 1 duplicated blocks of code must be removed.
java:S1118 (MAJOR) util/StreamTransferManagerHelper.java:13 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S3358 (MAJOR) avro/JsonToAvroSchemaConverter.java:179 Ternary operators should not be nested Extract this nested ternary operation into an independent statement.
java:S112 (MAJOR) s3/S3StorageOperations.java:127 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/S3StorageOperations.java:163 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/S3StorageOperations.java:173 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) csv/CsvSerializedBuffer.java:51 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S6213 (MAJOR) avro/S3AvroWriter.java:106 Restricted Identifiers should not be used as Identifiers Rename this variable to not match a restricted identifier.
java:S2259 (MAJOR) avro/JsonToAvroSchemaConverter.java:164 Null pointers should not be dereferenced A "NullPointerException" could be thrown; "properties" is nullable here.
java:S3776 (CRITICAL) avro/JsonToAvroSchemaConverter.java:338 Cognitive Complexity of methods should not be too high Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed.
java:S3252 (CRITICAL) avro/JsonToAvroSchemaConverter.java:372 "static" base class members should not be accessed via derived types Use static access with "!Unknown!" for "Entry".
java:S1121 (MAJOR) avro/JsonToAvroSchemaConverter.java:261 Assignments should not be made from within sub-expressions Extract the assignment out of this expression.
java:S107 (MAJOR) s3/S3DestinationConfig.java:42 Methods should not have too many parameters Constructor has 9 parameters, which is greater than 7 authorized.
java:S107 (MAJOR) csv/S3CsvWriter.java:40 Methods should not have too many parameters Constructor has 9 parameters, which is greater than 7 authorized.
java:S3358 (MAJOR) s3/S3Destination.java:141 Ternary operators should not be nested Extract this nested ternary operation into an independent statement.
java:S5361 (CRITICAL) s3/S3Destination.java:142 "String#replace" should be preferred to "String#replaceAll" Replace this call to "replaceAll()" by a call to the "replace()" method.
java:S1121 (MAJOR) avro/JsonToAvroSchemaConverter.java:217 Assignments should not be made from within sub-expressions Extract the assignment out of this expression.
java:S1118 (MAJOR) avro/AvroConstants.java:10 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S125 (MAJOR) avro/JsonToAvroSchemaConverter.java:209 Sections of code should not be commented out This block of commented-out lines of code should be removed.
java:S1068 (MAJOR) jsonl/S3JsonlWriter.java:37 Unused "private" fields should be removed Remove this unused "WRITER" private field.
java:S1118 (MAJOR) util/AvroRecordHelper.java:17 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S1700 (MAJOR) avro/JsonSchemaType.java:23 A field should not duplicate the name of its containing class Rename field "jsonSchemaType"
java:S1118 (MAJOR) parquet/S3ParquetConstants.java:9 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S1118 (MAJOR) util/S3OutputPathHelper.java:13 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S112 (MAJOR) writer/ProductionWriterFactory.java:59 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) writer/S3WriterFactory.java:21 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1118 (MAJOR) s3/S3FormatConfigs.java:16 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S112 (MAJOR) s3/S3FormatConfigs.java:39 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1118 (MAJOR) csv/CsvSheetGenerator.java:25 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S2094 (MINOR) csv/CsvSheetGenerators.java:7 Classes should not be empty Remove this empty class, write its code or make it an "interface".
java:S1116 (MINOR) csv/RootLevelFlatteningSheetGenerator.java:25 Empty statements should be removed Remove this empty statement.

Coverage (0.0%)

File Coverage File Coverage
src/main/java/io/airbyte/integrations/destination/s3/AesCbcEnvelopeEncryption.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/AesCbcEnvelopeEncryptionBlobDecorator.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/avro/AvroConstants.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/avro/AvroNameTransformer.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/avro/AvroRecordFactory.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/avro/AvroSerializedBuffer.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/avro/JsonFieldNameUpdater.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/avro/JsonSchemaType.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/avro/JsonToAvroSchemaConverter.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/avro/S3AvroFormatConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/avro/S3AvroWriter.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/BlobDecorator.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/BlobStorageOperations.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/credential/S3AccessKeyCredentialConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/credential/S3InstanceProfileCredentialConfig.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/csv/BaseSheetGenerator.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/csv/CsvSerializedBuffer.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/csv/CsvSheetGenerator.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/csv/NoFlatteningSheetGenerator.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/csv/RootLevelFlatteningSheetGenerator.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/csv/S3CsvFormatConfig.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/csv/S3CsvWriter.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/csv/StagingDatabaseCsvSheetGenerator.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/EncryptionConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/jsonl/JsonLSerializedBuffer.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/jsonl/S3JsonlFormatConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/jsonl/S3JsonlWriter.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/parquet/ParquetSerializedBuffer.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/parquet/S3ParquetConstants.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/parquet/S3ParquetFormatConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/parquet/S3ParquetWriter.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/S3ConsumerFactory.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/S3Destination.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/S3DestinationConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/S3DestinationConfigFactory.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/S3DestinationConstants.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/S3Format.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/S3FormatConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/S3FormatConfigs.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/S3StorageOperations.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/SerializedBufferFactory.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/util/AvroRecordHelper.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/util/CompressionType.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/util/CompressionTypeHelper.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/util/S3NameTransformer.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/util/S3OutputPathHelper.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/util/StreamTransferManagerHelper.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/util/StreamTransferManagerWithMetadata.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/WriteConfig.java 0.0 src/main/java/io/airbyte/integrations/destination/s3/writer/BaseS3Writer.java 0.0
src/main/java/io/airbyte/integrations/destination/s3/writer/ProductionWriterFactory.java 0.0

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Destination Gcs(#12452)

Measures

Name Value Name Value Name Value
Reliability Rating A Lines to Cover 298 Quality Gate Status OK
Code Smells 6 Bugs 0 Duplicated Blocks 0
Coverage 0.0 Duplicated Lines (%) 0.0 Security Rating A
Lines of Code 745 Vulnerabilities 0 Blocker Issues 0
Critical Issues 0 Major Issues 5 Minor Issues 1

Detected Issues

Rule File Description Message
java:S1301 (MINOR) gcs/GcsDestinationConfig.java:60 "switch" statements should have at least 3 "case" clauses Replace this "switch" statement by "if" statements to increase readability.
java:S6213 (MAJOR) avro/GcsAvroWriter.java:97 Restricted Identifiers should not be used as Identifiers Rename this variable to not match a restricted identifier.
java:S1118 (MAJOR) util/GcsUtils.java:16 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S1118 (MAJOR) credential/GcsCredentialConfigs.java:10 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S112 (MAJOR) credential/GcsCredentialConfigs.java:19 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1068 (MAJOR) parquet/GcsParquetWriter.java:39 Unused "private" fields should be removed Remove this unused "MAPPER" private field.

Coverage (0.0%)

File Coverage File Coverage
src/main/java/io/airbyte/integrations/destination/gcs/avro/GcsAvroWriter.java 0.0 src/main/java/io/airbyte/integrations/destination/gcs/credential/GcsCredentialConfigs.java 0.0
src/main/java/io/airbyte/integrations/destination/gcs/credential/GcsHmacKeyCredentialConfig.java 0.0 src/main/java/io/airbyte/integrations/destination/gcs/csv/GcsCsvWriter.java 0.0
src/main/java/io/airbyte/integrations/destination/gcs/GcsDestination.java 0.0 src/main/java/io/airbyte/integrations/destination/gcs/GcsDestinationConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/gcs/GcsStorageOperations.java 0.0 src/main/java/io/airbyte/integrations/destination/gcs/jsonl/GcsJsonlWriter.java 0.0
src/main/java/io/airbyte/integrations/destination/gcs/parquet/GcsParquetWriter.java 0.0 src/main/java/io/airbyte/integrations/destination/gcs/util/GcsS3FileSystem.java 0.0
src/main/java/io/airbyte/integrations/destination/gcs/util/GcsUtils.java 0.0 src/main/java/io/airbyte/integrations/destination/gcs/writer/BaseGcsWriter.java 0.0

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Destination Jdbc(#12452)

Measures

Name Value Name Value Name Value
Code Smells 77 Quality Gate Status OK Lines of Code 1988
Bugs 0 Lines to Cover 884 Duplicated Lines (%) 1.1
Duplicated Blocks 2 Coverage 0.0 Reliability Rating A
Vulnerabilities 0 Security Rating A Blocker Issues 0
Critical Issues 7 Major Issues 61 Minor Issues 4

Detected Issues

Rule File Description Message
java:S3776 (CRITICAL) staging/StagingConsumerFactory.java:179 Cognitive Complexity of methods should not be too high Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.
common-java:DuplicatedBlocks (MAJOR) s3/S3StreamCopier.java Source files should not have any duplicated blocks 1 duplicated blocks of code must be removed.
java:S116 (MINOR) staging/StagingConsumerFactory.java:54 Field names should comply with a naming convention Rename this field "RANDOM_CONNECTION_ID" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
java:S112 (MAJOR) staging/StagingOperations.java:23 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) staging/StagingOperations.java:31 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) staging/StagingOperations.java:42 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) staging/StagingOperations.java:47 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
common-java:DuplicatedBlocks (MAJOR) azure/AzureBlobStorageStreamCopier.java Source files should not have any duplicated blocks 1 duplicated blocks of code must be removed.
java:S5993 (MAJOR) azure/AzureBlobStorageStreamCopier.java:58 Constructors of an "abstract" class should not be declared "public" Change the visibility of this constructor to "protected".
java:S107 (MAJOR) azure/AzureBlobStorageStreamCopier.java:58 Methods should not have too many parameters Constructor has 9 parameters, which is greater than 7 authorized.
java:S112 (MAJOR) azure/AzureBlobStorageStreamCopier.java:165 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) azure/AzureBlobStorageStreamCopierFactory.java:40 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S107 (MAJOR) azure/AzureBlobStorageStreamCopierFactory.java:44 Methods should not have too many parameters Method has 9 parameters, which is greater than 7 authorized.
java:S112 (MAJOR) azure/AzureBlobStorageStreamCopierFactory.java:53 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) staging/StagingOperations.java:52 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S2864 (MAJOR) jdbc/AbstractJdbcDestination.java:106 "entrySet()" should be iterated when both the key and value are needed Iterate over the "entrySet" instead of the "keySet".
java:S1214 (CRITICAL) constants/GlobalDataSizeConstants.java:10 Constants should not be defined in interfaces Move constants defined in this interfaces to another class or enum.
java:S112 (MAJOR) copy/StreamCopier.java:26 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1135 (INFO) gcs/GcsStreamCopier.java:128 Track uses of "TODO" tags Complete the task associated to this TODO comment.
java:S1135 (INFO) gcs/GcsStreamCopier.java:204 Track uses of "TODO" tags Complete the task associated to this TODO comment.
java:S1192 (CRITICAL) jdbc/JdbcSqlOperations.java:52 String literals should not be duplicated Define a constant instead of duplicating this literal "schema" 4 times.
java:S1192 (CRITICAL) jdbc/JdbcSqlOperations.java:61 String literals should not be duplicated Define a constant instead of duplicating this literal "table" 3 times.
java:S107 (MAJOR) staging/StagingConsumerFactory.java:56 Methods should not have too many parameters Method has 8 parameters, which is greater than 7 authorized.
java:S112 (MAJOR) jdbc/SqlOperations.java:37 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S107 (MAJOR) s3/S3StreamCopierFactory.java:43 Methods should not have too many parameters Method has 8 parameters, which is greater than 7 authorized.
java:S1611 (MINOR) staging/StagingConsumerFactory.java:183 Parentheses should be removed from a single lambda input parameter when its type is inferred Remove the parentheses around the "hasFailed" parameter (sonar.java.source not set. Assuming 8 or greater.)
java:S108 (MAJOR) staging/StagingConsumerFactory.java:211 Nested blocks of code should not be left empty Either remove or fill this block of code.
java:S1135 (INFO) jdbc/SqlOperationsUtils.java:84 Track uses of "TODO" tags Complete the task associated to this TODO comment.
java:S125 (MAJOR) jdbc/StagingFilenameGenerator.java:18 Sections of code should not be commented out This block of commented-out lines of code should be removed.
java:S5361 (CRITICAL) jdbc/AbstractJdbcDestination.java:80 "String#replace" should be preferred to "String#replaceAll" Replace this call to "replaceAll()" by a call to the "replace()" method.
java:S1172 (MAJOR) jdbc/JdbcBufferedConsumerFactory.java:82 Unused method parameters should be removed Remove this unused method parameter "now".
java:S112 (MAJOR) jdbc/JdbcSqlOperations.java:75 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S6213 (MAJOR) jdbc/JdbcSqlOperations.java:78 Restricted Identifiers should not be used as Identifiers Rename this variable to not match a restricted identifier.
java:S107 (MAJOR) copy/CopyConsumerFactory.java:37 Methods should not have too many parameters Method has 8 parameters, which is greater than 7 authorized.
java:S5993 (MAJOR) copy/CopyDestination.java:30 Constructors of an "abstract" class should not be declared "public" Change the visibility of this constructor to "protected".
java:S107 (MAJOR) gcs/GcsStreamCopier.java:69 Methods should not have too many parameters Constructor has 9 parameters, which is greater than 7 authorized.
java:S5993 (MAJOR) gcs/GcsStreamCopier.java:69 Constructors of an "abstract" class should not be declared "public" Change the visibility of this constructor to "protected".
java:S5993 (MAJOR) s3/S3StreamCopier.java:66 Constructors of an "abstract" class should not be declared "public" Change the visibility of this constructor to "protected".
java:S107 (MAJOR) s3/S3StreamCopier.java:66 Methods should not have too many parameters Constructor has 10 parameters, which is greater than 7 authorized.
java:S112 (MAJOR) copy/StreamCopier.java:19 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/S3StreamCopier.java:120 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S5993 (MAJOR) copy/CopyDestination.java:28 Constructors of an "abstract" class should not be declared "public" Change the visibility of this constructor to "protected".
java:S112 (MAJOR) jdbc/DataAdapter.java:57 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) jdbc/JdbcSqlOperations.java:153 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1192 (CRITICAL) gcs/GcsConfig.java:35 String literals should not be duplicated Define a constant instead of duplicating this literal "loading_method" 3 times.
java:S1118 (MAJOR) copy/CopyConsumerFactory.java:33 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S1135 (INFO) copy/CopyConsumerFactory.java:99 Track uses of "TODO" tags Complete the task associated to this TODO comment.
java:S1611 (MINOR) copy/CopyConsumerFactory.java:123 Parentheses should be removed from a single lambda input parameter when its type is inferred Remove the parentheses around the "hasFailed" parameter (sonar.java.source not set. Assuming 8 or greater.)
java:S112 (MAJOR) jdbc/SqlOperations.java:110 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) gcs/GcsStreamCopier.java:111 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S5361 (CRITICAL) gcs/GcsStreamCopier.java:214 "String#replace" should be preferred to "String#replaceAll" Replace this call to "replaceAll()" by a call to the "replace()" method.
java:S112 (MAJOR) gcs/GcsStreamCopierFactory.java:50 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S107 (MAJOR) gcs/GcsStreamCopierFactory.java:57 Methods should not have too many parameters Method has 9 parameters, which is greater than 7 authorized.
java:S112 (MAJOR) gcs/GcsStreamCopierFactory.java:66 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) jdbc/SqlOperations.java:89 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S5993 (MAJOR) jdbc/AbstractJdbcDestination.java:46 Constructors of an "abstract" class should not be declared "public" Change the visibility of this constructor to "protected".
java:S112 (MAJOR) copy/StreamCopier.java:32 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) copy/StreamCopier.java:37 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) copy/StreamCopier.java:43 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) copy/StreamCopier.java:48 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) copy/StreamCopier.java:55 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) copy/StreamCopier.java:60 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) copy/StreamCopier.java:66 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/S3StreamCopierFactory.java:36 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) s3/S3StreamCopierFactory.java:51 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S108 (MAJOR) jdbc/JdbcBufferedConsumerFactory.java:174 Nested blocks of code should not be left empty Either remove or fill this block of code.
java:S108 (MAJOR) jdbc/JdbcBufferedConsumerFactory.java:175 Nested blocks of code should not be left empty Either remove or fill this block of code.
java:S1118 (MAJOR) jdbc/JdbcBufferedConsumerFactory.java:47 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S1611 (MINOR) jdbc/JdbcBufferedConsumerFactory.java:158 Parentheses should be removed from a single lambda input parameter when its type is inferred Remove the parentheses around the "hasFailed" parameter (sonar.java.source not set. Assuming 8 or greater.)
java:S3457 (MAJOR) jdbc/JdbcSqlOperations.java:93 Printf-style format strings should be used correctly %n should be used in place of \n to produce the platform-specific line separator.
java:S3457 (MAJOR) jdbc/JdbcSqlOperations.java:98 Printf-style format strings should be used correctly %n should be used in place of \n to produce the platform-specific line separator.
java:S3457 (MAJOR) jdbc/JdbcSqlOperations.java:122 Printf-style format strings should be used correctly %n should be used in place of \n to produce the platform-specific line separator.
java:S1135 (INFO) jdbc/SqlOperations.java:15 Track uses of "TODO" tags Complete the task associated to this TODO comment.
java:S112 (MAJOR) jdbc/SqlOperations.java:28 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) jdbc/SqlOperations.java:49 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) jdbc/SqlOperations.java:68 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1118 (MAJOR) jdbc/SqlOperationsUtils.java:20 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.

Coverage (0.0%)

File Coverage File Coverage
src/main/java/io/airbyte/integrations/destination/jdbc/AbstractJdbcDestination.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/constants/GlobalDataSizeConstants.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/copy/azure/AzureBlobStorageConfig.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/copy/azure/AzureBlobStorageStreamCopier.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/copy/azure/AzureBlobStorageStreamCopierFactory.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/copy/CopyConsumerFactory.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/copy/CopyDestination.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/copy/gcs/GcsConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/copy/gcs/GcsStreamCopier.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/copy/gcs/GcsStreamCopierFactory.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/copy/s3/S3CopyConfig.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/copy/s3/S3StreamCopier.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/copy/s3/S3StreamCopierFactory.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/copy/StreamCopierFactory.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/copy/SwitchingDestination.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/DataAdapter.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/JdbcBufferedConsumerFactory.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/JdbcSqlOperations.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/SqlOperations.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/SqlOperationsUtils.java 0.0
src/main/java/io/airbyte/integrations/destination/jdbc/StagingFilenameGenerator.java 0.0 src/main/java/io/airbyte/integrations/destination/jdbc/WriteConfig.java 0.0
src/main/java/io/airbyte/integrations/destination/staging/StagingConsumerFactory.java 0.0

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Destination Snowflake(#12452)

Measures

Name Value Name Value Name Value
Quality Gate Status OK Lines of Code 1258 Lines to Cover 3
Duplicated Lines (%) 0.0 Vulnerabilities 0 Coverage 0.0
Code Smells 26 Duplicated Blocks 2 Reliability Rating A
Security Rating A Bugs 1 Blocker Issues 0
Critical Issues 10 Major Issues 16 Minor Issues 2

Detected Issues

Rule File Description Message
common-java:DuplicatedBlocks (MAJOR) snowflake/SnowflakeInternalStagingDestination.java Source files should not have any duplicated blocks 1 duplicated blocks of code must be removed.
common-java:DuplicatedBlocks (MAJOR) snowflake/SnowflakeS3StagingDestination.java Source files should not have any duplicated blocks 1 duplicated blocks of code must be removed.
java:S1192 (CRITICAL) snowflake/SnowflakeS3StagingDestination.java:48 String literals should not be duplicated Define a constant instead of duplicating this literal "loading_method" 4 times.
java:S1192 (CRITICAL) snowflake/SnowflakeDatabase.java:71 String literals should not be duplicated Define a constant instead of duplicating this literal "client_id" 4 times.
java:S1192 (CRITICAL) snowflake/SnowflakeDatabase.java:72 String literals should not be duplicated Define a constant instead of duplicating this literal "client_secret" 4 times.
java:S1192 (CRITICAL) snowflake/SnowflakeDatabase.java:72 String literals should not be duplicated Define a constant instead of duplicating this literal "refresh_token" 6 times.
java:S112 (MAJOR) snowflake/SnowflakeDatabase.java:74 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1192 (CRITICAL) snowflake/SnowflakeDatabase.java:89 String literals should not be duplicated Define a constant instead of duplicating this literal "password" 3 times.
java:S112 (MAJOR) snowflake/SnowflakeDatabase.java:164 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S2142 (MAJOR) snowflake/SnowflakeDatabase.java:167 "InterruptedException" should not be ignored Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here.
java:S1192 (CRITICAL) snowflake/SnowflakeInternalStagingSqlOperations.java:91 String literals should not be duplicated Define a constant instead of duplicating this literal "stage" 5 times.
java:S112 (MAJOR) snowflake/SnowflakeInternalStagingSqlOperations.java:96 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1192 (CRITICAL) snowflake/SnowflakeInternalStagingSqlOperations.java:98 String literals should not be duplicated Define a constant instead of duplicating this literal "Executing query: {}" 6 times.
java:S112 (MAJOR) snowflake/SnowflakeInternalStagingSqlOperations.java:103 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S3457 (MAJOR) snowflake/SnowflakeInternalStagingSqlOperations.java:164 Printf-style format strings should be used correctly Format specifiers should be used instead of string concatenation.
java:S117 (MINOR) snowflake/SnowflakeS3StagingDestination.java Local variable and method parameter names should comply with a naming convention Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
java:S112 (MAJOR) snowflake/SnowflakeS3StagingDestination.java:77 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1192 (CRITICAL) snowflake/SnowflakeS3StagingSqlOperations.java:84 String literals should not be duplicated Define a constant instead of duplicating this literal "stage" 4 times.
java:S1155 (MINOR) snowflake/SnowflakeSqlOperations.java:66 Collection.isEmpty() should be used to test for emptiness Use isEmpty() to check whether the collection is empty or not.
java:S112 (MAJOR) snowflake/SnowflakeAzureBlobStorageStreamCopier.java:61 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S1192 (CRITICAL) snowflake/SnowflakeDestinationResolver.java:28 String literals should not be duplicated Define a constant instead of duplicating this literal "loading_method" 9 times.
java:S1118 (MAJOR) snowflake/SnowflakeDestinationResolver.java:13 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.
java:S112 (MAJOR) snowflake/SnowflakeGcsStreamCopier.java:79 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) snowflake/SnowflakeParallelCopyStreamCopier.java:40 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S112 (MAJOR) snowflake/SnowflakeS3StreamCopier.java:121 Generic exceptions should never be thrown Define and throw a dedicated exception instead of using a generic one.
java:S5361 (CRITICAL) snowflake/SnowflakeInternalStagingDestination.java:66 "String#replace" should be preferred to "String#replaceAll" Replace this call to "replaceAll()" by a call to the "replace()" method.
java:S1068 (MAJOR) snowflake/SnowflakeInsertDestination.java:19 Unused "private" fields should be removed Remove this unused "LOGGER" private field.
java:S1118 (MAJOR) snowflake/SnowflakeDatabase.java:36 Utility classes should not have public constructors Add a private constructor to hide the implicit public one.

Coverage (0.0%)

File Coverage File Coverage
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeAzureBlobStorageStreamCopier.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeAzureBlobStorageStreamCopierFactory.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeCopyAzureBlobStorageDestination.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeCopyGcsDestination.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestination.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationResolver.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeGcsStreamCopier.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeGcsStreamCopierFactory.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeInsertDestination.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeInternalStagingDestination.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeInternalStagingSqlOperations.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeParallelCopyStreamCopier.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeS3StagingDestination.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeS3StagingSqlOperations.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeS3StreamCopier.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeS3StreamCopierFactory.java 0.0 src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeSQLNameTransformer.java 0.0
src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeSqlOperations.java 0.0

Please sign in to comment.