Skip to content

Commit

Permalink
Remove deprecated connector dependency report (#18889)
Browse files Browse the repository at this point in the history
* Update action and template

* Bump version for testing

* Revert change to test comment update

* Update action

* Update action

* Add comment

* Test change again

* Update comment

* Revert change for testing

* Add comment

* Fix typos
  • Loading branch information
tuliren authored Nov 3, 2022
1 parent 418d0ca commit a5f72d2
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
10 changes: 9 additions & 1 deletion .github/comment_templates/connector_dependency_template.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<!--- this comment is for `report-connectors-dependency.yml` identification, do not remove -->

## Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:
- Run integration tests
- Bump connector version
Expand All @@ -17,6 +19,8 @@ NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do
| --- | :---: | :---: | :---: |
{source_rows}

* See "Actionable Items" below for how to resolve warnings and errors.

</details>

<details {destination_open}>
Expand All @@ -30,6 +34,8 @@ NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do
| --- | :---: | :---: | :---: |
{destination_rows}

* See "Actionable Items" below for how to resolve warnings and errors.

</details>

{others}
Expand All @@ -38,7 +44,9 @@ NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do

<summary>

### Notes
### Actionable Items

(click to expand)

</summary>

Expand Down
14 changes: 13 additions & 1 deletion .github/workflows/report-connectors-dependency.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ jobs:
echo "comment=true" >> $GITHUB_OUTPUT
fi
- name: Find existing comment for connector dependencies
if: steps.dependency_report.outputs.comment == 'true'
# Always run this step because the action may need to
# remove a comment created from a previous commit.
uses: peter-evans/find-comment@v2
id: find_comment
with:
Expand All @@ -40,3 +41,14 @@ jobs:
comment-id: ${{ steps.find_comment.outputs.comment-id }}
edit-mode: "replace"
body-file: "comment_body.md"
- name: Remove deprecated report in PR
if: steps.dependency_report.outputs.comment != 'true' && steps.find_comment.outputs.comment-id != ''
uses: peter-evans/create-or-update-comment@v2
with:
issue-number: ${{ github.event.pull_request.number }}
comment-id: ${{ steps.find_comment.outputs.comment-id }}
edit-mode: "replace"
body: |
<!--- this comment is for `report-connectors-dependency.yml` identification, do not remove -->
## Affected Connector Report
The latest commit has removed all connector-related changes. There are no more dependent connectors for this PR.

0 comments on commit a5f72d2

Please sign in to comment.