Skip to content

Commit

Permalink
🐛 Destination GCS: Fix error logs to log 'Gcs' rather than 'AWS' (#17901
Browse files Browse the repository at this point in the history
)

* Fix error logs to log 'Gcs' rather than 'AWS'

* update connector version

* auto-bump connector version

Co-authored-by: marcosmarxm <[email protected]>
Co-authored-by: Octavia Squidington III <[email protected]>
  • Loading branch information
3 people authored Oct 18, 2022
1 parent 19a296c commit d9a48c9
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
- name: Google Cloud Storage (GCS)
destinationDefinitionId: ca8f6566-e555-4b40-943a-545bf123117a
dockerRepository: airbyte/destination-gcs
dockerImageTag: 0.2.11
dockerImageTag: 0.2.12
documentationUrl: https://docs.airbyte.com/integrations/destinations/gcs
icon: googlecloudstorage.svg
resourceRequirements:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1983,7 +1983,7 @@
supported_destination_sync_modes:
- "overwrite"
- "append"
- dockerImage: "airbyte/destination-gcs:0.2.11"
- dockerImage: "airbyte/destination-gcs:0.2.12"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/destinations/gcs"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-gcs/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-gcs

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.2.11
LABEL io.airbyte.version=0.2.12
LABEL io.airbyte.name=airbyte/destination-gcs
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ public AirbyteConnectionStatus check(final JsonNode config) {

return new AirbyteConnectionStatus().withStatus(Status.SUCCEEDED);
} catch (final AmazonS3Exception e) {
LOGGER.error("Exception attempting to access the AWS bucket: {}", e.getMessage());
LOGGER.error("Exception attempting to access the Gcs bucket: {}", e.getMessage());
final String message = getErrorMessage(e.getErrorCode(), 0, e.getMessage(), e);
AirbyteTraceMessageUtility.emitConfigErrorTrace(e, message);
return new AirbyteConnectionStatus()
.withStatus(Status.FAILED)
.withMessage(message);
} catch (final Exception e) {
LOGGER.error("Exception attempting to access the AWS bucket: {}. Please make sure you account has all of these roles: {}", e.getMessage(),
LOGGER.error("Exception attempting to access the Gcs bucket: {}. Please make sure you account has all of these roles: {}", e.getMessage(),
EXPECTED_ROLES);
AirbyteTraceMessageUtility.emitConfigErrorTrace(e, e.getMessage());
return new AirbyteConnectionStatus()
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/gcs.md
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ Under the hood, an Airbyte data stream in Json schema is first converted to an A

| Version | Date | Pull Request | Subject |
|:--------| :--- | :--- | :--- |
| 0.2.12 | 2022-10-18 | [\#17901](https://github.com/airbytehq/airbyte/pull/17901) | Fix logging to GCS |
| 0.2.11 | 2022-09-01 | [\#16243](https://github.com/airbytehq/airbyte/pull/16243) | Fix Json to Avro conversion when there is field name clash from combined restrictions (`anyOf`, `oneOf`, `allOf` fields) |
| 0.2.10 | 2022-08-05 | [\#14801](https://github.com/airbytehq/airbyte/pull/14801) | Fix multiple log bindings |
| 0.2.9 | 2022-06-24 | [\#14114](https://github.com/airbytehq/airbyte/pull/14114) | Remove "additionalProperties": false from specs for connectors with staging |
Expand Down

0 comments on commit d9a48c9

Please sign in to comment.