🍾 Remove automatic filtering of system schemas from Oracle source. (#…

…6038) * Remove default schemas from Oracle source. * Bump version and update changelog.
airbytehq · Sep 14, 2021 · dc71bf6 · dc71bf6
1 parent fa0028d
commit dc71bf6
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -289,7 +289,7 @@
 - sourceDefinitionId: b39a7370-74c3-45a6-ac3a-380d48520a83
   name: Oracle DB
   dockerRepository: airbyte/source-oracle
-  dockerImageTag: 0.3.3
+  dockerImageTag: 0.3.4
   documentationUrl: https://docs.airbyte.io/integrations/sources/oracle
 - sourceDefinitionId: c8630570-086d-4a40-99ae-ea5b18673071
   name: Zendesk Talk

diff --git a/airbyte-integrations/connectors/source-oracle/Dockerfile b/airbyte-integrations/connectors/source-oracle/Dockerfile
@@ -9,5 +9,5 @@ COPY build/distributions/${APPLICATION}*.tar ${APPLICATION}.tar
 
 RUN tar xf ${APPLICATION}.tar --strip-components=1
 
-LABEL io.airbyte.version=0.3.3
+LABEL io.airbyte.version=0.3.4
 LABEL io.airbyte.name=airbyte/source-oracle
diff --git a/...ctors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java b/...ctors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
@@ -94,10 +94,13 @@ public List<TableInfo<CommonField<JDBCType>>> discoverInternal(JdbcDatabase data
     return internals;
   }
 
+  /**
+   * Since the Oracle connector allows a user to specify schemas, and picks a default schemas
+   * otherwise, system tables are never included, and do not need to be excluded by default.
+   */
   @Override
   public Set<String> getExcludedInternalNameSpaces() {
-    // need to add SYSTEM too but for that need create another user when creating the container.
-    return Set.of("APEX_040000", "CTXSYS", "SYSTEM", "FLOWS_FILES", "HR", "MDSYS", "OUTLN", "SYS", "XDB");
+    return Set.of();
   }
 
   public static void main(String[] args) throws Exception {

diff --git a/docs/integrations/sources/oracle.md b/docs/integrations/sources/oracle.md
@@ -105,5 +105,6 @@ Case sensitive. Defaults to the upper-cased user if empty. If the user does not
 
 | Version | Date       | Pull Request | Subject |
 | :------ | :--------  | :-----       | :------ |
+| 0.3.4   | 2021-09-01 | [6038](https://github.com/airbytehq/airbyte/pull/6038) | Remove automatic filtering of system schemas. |
 | 0.3.3   | 2021-09-01 | [5779](https://github.com/airbytehq/airbyte/pull/5779) | Ability to only discover certain schemas. |
 | 0.3.2   | 2021-08-13 | [4699](https://github.com/airbytehq/airbyte/pull/4699) | Added json config validator. |