Remove signup source selection experiment (#21819)

airbytehq · Jan 25, 2023 · ecc17b6 · ecc17b6
1 parent 113b134
commit ecc17b6
Show file tree

Hide file tree

Showing 12 changed files with 2 additions and 1,918 deletions.
diff --git a/airbyte-webapp/src/hooks/services/Experiment/experiments.ts b/airbyte-webapp/src/hooks/services/Experiment/experiments.ts
@@ -21,7 +21,6 @@ export interface Experiments {
   "authPage.oauth.google.signUpPage": boolean;
   "authPage.oauth.github.signUpPage": boolean;
   "onboarding.speedyConnection": boolean;
-  "authPage.signup.sourceSelector": boolean;
   "authPage.oauth.position": "top" | "bottom";
   "connection.onboarding.sources": string;
   "connection.onboarding.destinations": string;

diff --git a/airbyte-webapp/src/hooks/useLocationState.ts b/airbyte-webapp/src/hooks/useLocationState.ts
diff --git a/...p/src/packages/cloud/components/experiments/SignupSourceDropdown/SignupSourceDropdown.tsx b/...p/src/packages/cloud/components/experiments/SignupSourceDropdown/SignupSourceDropdown.tsx
diff --git a/airbyte-webapp/src/packages/cloud/components/experiments/SignupSourceDropdown/index.ts b/airbyte-webapp/src/packages/cloud/components/experiments/SignupSourceDropdown/index.ts
diff --git a/...app/src/packages/cloud/components/experiments/SignupSourceDropdown/sourceDefinitions.json b/...app/src/packages/cloud/components/experiments/SignupSourceDropdown/sourceDefinitions.json
diff --git a/...rc/packages/cloud/components/experiments/SignupSourceDropdown/useGetSourceDefinitions.tsx b/...rc/packages/cloud/components/experiments/SignupSourceDropdown/useGetSourceDefinitions.tsx
diff --git a/airbyte-webapp/src/packages/cloud/components/experiments/SignupSourceDropdown/utils.tsx b/airbyte-webapp/src/packages/cloud/components/experiments/SignupSourceDropdown/utils.tsx
diff --git a/airbyte-webapp/src/packages/cloud/components/experiments/constants.ts b/airbyte-webapp/src/packages/cloud/components/experiments/constants.ts
diff --git a/airbyte-webapp/src/packages/cloud/locales/en.json b/airbyte-webapp/src/packages/cloud/locales/en.json
@@ -41,7 +41,6 @@
   "login.oauth.github": "Continue with GitHub",
   "login.oauth.differentCredentialsError": "Use your email and password to sign in.",
   "login.oauth.unknownError": "An unknown error happened during sign in: {error}",
-  "login.sourceSelector": "Select a source to get started",
 
   "confirmResetPassword.newPassword": "Enter a new password",
   "confirmResetPassword.success": "Your password has been reset. Please log in with the new password.",

diff --git a/airbyte-webapp/src/packages/cloud/views/DefaultView.tsx b/airbyte-webapp/src/packages/cloud/views/DefaultView.tsx
@@ -1,22 +1,12 @@
-import { useEffect } from "react";
 import { Navigate } from "react-router-dom";
 
-import { useExperiment } from "hooks/services/Experiment";
-
 import { RoutePaths } from "../../../pages/routePaths";
 import { CloudRoutes } from "../cloudRoutePaths";
-import { EXP_SOURCE_SIGNUP_SELECTOR } from "../components/experiments/constants";
 import { useListCloudWorkspaces } from "../services/workspaces/CloudWorkspacesService";
 
 export const DefaultView: React.FC = () => {
   const workspaces = useListCloudWorkspaces();
-  // exp-signup-selected-source-definition
-  const isSignupSourceSelectorExperiment = useExperiment("authPage.signup.sourceSelector", false);
-  const sourceDefinitionId = localStorage.getItem(EXP_SOURCE_SIGNUP_SELECTOR);
 
-  useEffect(() => {
-    localStorage.removeItem(EXP_SOURCE_SIGNUP_SELECTOR);
-  }, []);
   // Only show the workspace creation list if there is more than one workspace
   // otherwise redirect to the single workspace
   return (
@@ -27,12 +17,6 @@ export const DefaultView: React.FC = () => {
           : `/${RoutePaths.Workspaces}/${workspaces[0].workspaceId}`
       }
       replace
-      // exp-signup-selected-source-definition
-      {...(isSignupSourceSelectorExperiment &&
-        sourceDefinitionId && {
-          state: { sourceDefinitionId },
-          to: `/${RoutePaths.Workspaces}/${workspaces[0].workspaceId}/${RoutePaths.Connections}/${RoutePaths.ConnectionNew}`,
-        })}
     />
   );
 };

diff --git a/airbyte-webapp/src/packages/cloud/views/auth/SignupPage/components/SignupForm.tsx b/airbyte-webapp/src/packages/cloud/views/auth/SignupPage/components/SignupForm.tsx
@@ -9,7 +9,6 @@ import { LabeledInput, Link } from "components";
 import { Button } from "components/ui/Button";
 
 import { useExperiment } from "hooks/services/Experiment";
-import { SignupSourceDropdown } from "packages/cloud/components/experiments/SignupSourceDropdown";
 import { FieldError } from "packages/cloud/lib/errors/FieldError";
 import { useAuthService } from "packages/cloud/services/auth/AuthService";
 import { isGdprCountry } from "utils/dataPrivacy";
@@ -172,7 +171,6 @@ export const SignupForm: React.FC = () => {
 
   const showName = !useExperiment("authPage.signup.hideName", false);
   const showCompanyName = !useExperiment("authPage.signup.hideCompanyName", false);
-  const showSourceSelector = useExperiment("authPage.signup.sourceSelector", false);
 
   const validationSchema = useMemo(() => {
     const shape = {
@@ -216,21 +214,14 @@ export const SignupForm: React.FC = () => {
       validateOnBlur
       validateOnChange
     >
-      {({ isValid, isSubmitting, status, values }) => (
+      {({ isValid, isSubmitting, status }) => (
         <Form>
           {(showName || showCompanyName) && (
             <RowFieldItem>
               {showName && <NameField />}
               {showCompanyName && <CompanyNameField />}
             </RowFieldItem>
           )}
-
-          {/* exp-select-source-signup */}
-          {showSourceSelector && (
-            <FieldItem>
-              <SignupSourceDropdown disabled={isSubmitting} email={values.email} />
-            </FieldItem>
-          )}
           <FieldItem>
             <EmailField />
           </FieldItem>