Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty config objects inside oneOfs cannot be saved #12457

Closed
edgao opened this issue Apr 28, 2022 · 1 comment · Fixed by #15109
Closed

Empty config objects inside oneOfs cannot be saved #12457

edgao opened this issue Apr 28, 2022 · 1 comment · Fixed by #15109
Assignees
Labels
area/frontend Related to the Airbyte webapp needs-triage type/bug Something isn't working

Comments

@edgao
Copy link
Contributor

edgao commented Apr 28, 2022

When I create a destination-snowflake connector using the AWS S3 Staging mode, then refresh the page and try to switch to the [Recommended] Internal Staging option, the Save changes and retest button remains grayed out:
Screen Shot 2022-04-28 at 3 07 25 PM

The spec, for reference (this is on master):

{
"title": "[Recommended] Internal Staging",
"additionalProperties": false,
"description": "Writes large batches of records to a file, uploads the file to Snowflake, then uses <pre>COPY INTO table</pre> to upload the file. Recommended for large production workloads for better speed and scalability.",
"required": ["method"],
"properties": {
"method": {
"type": "string",
"enum": ["Internal Staging"],
"default": "Internal Staging"
}
}
},

This seems to happen for any empty object inside a oneOf, e.g. I see the same behavior on a branch where I've added another empty object: https://github.com/airbytehq/airbyte/blob/2e14eacdb5b00aa7386a243e968bc5000a355606/airbyte-integrations/connectors/destination-snowflake/src/main/resources/spec.json#L258-L271

@edgao edgao added type/bug Something isn't working area/frontend needs-triage area/frontend Related to the Airbyte webapp labels Apr 28, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp needs-triage type/bug Something isn't working
Projects
None yet
4 participants