🪟 🐛 Update <ConditionSection /> to update values after form validation is updated

[edmundito]

What

Fixes #12457

This updates the ConditionSection component only to update the value after form validation has been set because otherwise, it tries to validate the fields before the validation is updated. This case is specific to when the condition has no values to fill out.

How

In the ConditionSection component, both the form value and widgetsInfo would be updated one after the other. When widgetsInfo is updated, it updates the form validation because the form shape has changed (from the previously selected condition to the new one). Now it re-runs validation after widgetsInfo updates the component flagged for re-validation.

Recommended reading order

• One file to read

Tests

• Tested on snowflake destination

[teallarson]

Code LGTM. I can't get a Snowflake/S3 destination set up with the credentials in lastpass so have not tested the usecase from the original issue.

[timroes]

When I reviewed this, I was thinking: Don't we have code that does exactly that revalidation of a form when the validation schema changes, and came across: https://github.com/airbytehq/airbyte/blob/master/airbyte-webapp/src/views/Connector/ServiceForm/useBuildForm.tsx#L127-L129

Digging a bit deeper, it seems this does currently not work because of a Formik bug (jaredpalmer/formik#2092) that simply always returns undefined when trying to get the validationSchema from the formik context (no matter that there is actually a proper validationSchema).

I opened a PR trying to fix that high-level code: #15109 which could superseed this PR. From what I've tested this should fix the problem as well, and gets rid of the high level non-working code anymore (in useBuildForm). Could you maybe double check if that fixes the same issue, and if we can superseed this PR by #15109?

[timroes]

Digging into this I also created #15108, which I believe is what we should eventually trying to go for and not have validationSchemas changing over time.

[edmundito]

Replaced by #15109 - Tested after merge and fixes the issue.