Empty space with barely noticeable message if no Setup Guide is found for source/destination

[dizel852]

Environment

• Airbyte version: 0.39.13-alpha
• OS Version / Instance: macOS
• Deployment: Cloud, OSS, Prod
• Source Connector and version: Google Ads 0.1.40
• Step where error happened: Sources /New Source / Choose Google Ads

Current Behavior

If the source/destination does not have the setup guide, the screen remains split with a barely noticeable message "No Setup Guide found for this connector."

Expected Behavior

If there is no setup guide probably would be better to show some nice placeholder(or "request setup guide" button in order to understand how many users need it)

Steps to Reproduce

1. Open Sources tab
2. Click New Source button
3. Choose Google Ads source

[octavia-squidington-iii]

cc @airbytehq/frontend

[teallarson]

This is an interesting issue! Thanks for surfacing it @dizel852. A bigger problem here: We have Google Ads docs, but ad-blockers prevent the markdown from rendering. There are only two connectors without docs and they are pretty lightly used. The two tasks here are:

1. Create a workaround for Google Ads docs to render (I've outlined a plan with @timroes and am looking into it)
2. Consider adding better design for missing docs state

[marcosmarxm]

@tealjulia should I open a different issue to deal with custom connectors?

[timroes]

@marcosmarxm that looks indeed like a separate bug. Could you please also state what the documentationUrl is that this connector returns in a new bug issue. This looks like we're breaking on transforming/parsing this URL actually. Also is this happening in a deployed instance or when running the FE via npm (since we handle documentation different in those two cases).

[teallarson]

@andyjih You had previously approved the simple "No Setup Guide found for this connector" for missing docs (AFAIK currently only Mailgun and Firestore and Firestore (OSS only I believe)).

Is it worth looking into a redesign of this page for that or should I close the Issue when the Google Ads fix is merged?

[andyjih]

@tealjulia Do we know if the adblocker is blocking only Google-related docs pages or pages?

If it's only affecting this Google Ads page, then I don't think we need to redesign the page further as it's still only affecting those 2 plugins.

[teallarson]

@andyjih I tried the other connectors containing "Ad" and "Google" and Google Ads was the only one that I could find with this issue.

[andyjih]

@tealjulia Cool, then I think it's fine to keep the existing design for now. Thanks!

[teallarson]

Closing -- Google Ads docs issue has been fixed.