Render Google Ads docs for users with Adblockers #13681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adresses part of #13555
Before: Users with adblocker browser plugins would not see our Google Ads documentation in our documentation side panel. They would instead see "no documentation found for this connector". But we do have (beautiful) docs for it!
This only appears to have affected Google Ads. Not other plugins with the word Ad and not other plugins with the word Google.
Now: Users can see the docs 🎉
Note: The H1 is still stripped out. This appears to affect a few docs when Adblockers are on. I'm not addressing that in this PR.
How
google-ads.md
asgglad.md
google-ads.md
ifgglad.md
is requested so users on localhost see the right docsgoogle-ads
is replaced bygglad
Recommended reading order
DocumenationPanelContext.tsx
build.gradle
setupProxy.js
Testing
Testing this with various ad-blocking plugins may be helpful. I've tested it manually using Adblock Plus on Firefox and Chrome.
SUB_BUILD=PLATFORM ./gradlew :airbyte-webapp:copyDocs --rerun-tasks
. This will rebuild the docs.airbyte-webapp
runnpm start