-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source TikTok Marketing : Access token is null #14299
Comments
Comment made from Zendesk by Marcos Marx on 2022-06-30 at 14:30:
|
The request from the web UI sent the acess token, but looking at the |
I have confirmed the same issue in my local OSS deployment and on CLOUD. Important: issue also happens with old versions of tiktok connector: However, connector is working when to run commands in CLI: (.venv) vratniuk@KBP1-LHP-A10380 ~/air/airbyte/airbyte-integrations/connectors/source-tiktok-marketing (master)$ python main.py check --config secrets/prod_config.json (.venv) vratniuk@KBP1-LHP-A10380 ~/air/airbyte/airbyte-integrations/connectors/source-tiktok-marketing (master)$ docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-tiktok-marketing:dev check --config /secrets/prod_config.json THE PROBLEM WITH SANDBOX account (from API side) |
The problem indeed happens because source container receives config file with empty access_token in it, check example: {"credentials":{"access_token":"","auth_type":"oauth2.0","secret":"","app_id":""},"start_date":"2021-04-01"} as for me it looks like a problem with UI. Edit benmoriceau: sanitize secrets |
@midavadim I was able to get the access token if I use order in the spec class. airbyte/airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/spec.py Lines 16 to 36 in 5cdf2f4
|
I will take a look at the issue from the Java side |
Found the root cause of the issue, looks like it was introduced in the and of June in the scope of this PR |
Oncall team is investigating this issue. |
FYI @misteryeo the fix is on the airbyte review |
* Replaced List with Set in order to avoid credentials loosing for case when we have multiple options with the same key on spec * returned back List to save the order of fields, added distinct() to have a unique path values * clean up * [14299] Source TikTok Marketing : Access token is null added unit tests * [14299] Source TikTok Marketing : Access token is null updated javadoc * Format Co-authored-by: Tuhai Maksym <[email protected]> Co-authored-by: Benoit Moriceau <[email protected]>
This Github issue is synchronized with Zendesk:
Ticket ID: #1385
Priority: normal
Group: User Success Engineer
Assignee: Marcos Marx
Original ticket description:
The text was updated successfully, but these errors were encountered: