Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Connection prop drilling, use Connection Edit Service #17345

Closed
krishnaglick opened this issue Sep 28, 2022 · 3 comments
Closed

Remove Connection prop drilling, use Connection Edit Service #17345

krishnaglick opened this issue Sep 28, 2022 · 3 comments
Labels
area/frontend Related to the Airbyte webapp team/platform-move

Comments

@krishnaglick
Copy link
Contributor

Looking at ConnectionItemPage, the TransformationView, StatusView, and SettingsView have the connection object prop-drilled. They should use the ConnectionEditService instead and this change should be propagated downwards where appropriate.

Example: StateBlock.tsx has the connectionId prop-drilled. Can just pull it out of the service.

Please verify that every component changed in this way is not used in places not wrapped with the service!
@salima-airbyte salima-airbyte added the area/frontend Related to the Airbyte webapp label Sep 28, 2022
@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@edmundito
Copy link
Contributor

Similar to #15609 ?

@krishnaglick
Copy link
Contributor Author

Oh, you're right!

@edmundito edmundito closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@edmundito @krishnaglick @salima-airbyte @octavia-squidington-iv