Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate other children of ConnectionItemPage to use ConnectionFormService #15609

Closed
teallarson opened this issue Aug 12, 2022 · 1 comment · Fixed by #17808
Closed

Migrate other children of ConnectionItemPage to use ConnectionFormService #15609

teallarson opened this issue Aug 12, 2022 · 1 comment · Fixed by #17808
Assignees
@teallarson
Labels
area/frontend Related to the Airbyte webapp team/platform-move

Comments

@teallarson
Copy link
Contributor

Now that we have the ConnectionService, ConnectionItemPage and its children can be refactored to implement it rather than passing the connection object/connection id directly.
@teallarson teallarson added the area/frontend Related to the Airbyte webapp label Aug 12, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@teallarson teallarson changed the title Migrate other children of ConnectionItemPage to use ConnectionService Migrate other children of ConnectionItemPage to use ConnectionFormService Aug 12, 2022
@edmundito edmundito mentioned this issue Sep 28, 2022
Closed
@teallarson teallarson mentioned this issue Oct 6, 2022
Merged
@teallarson teallarson self-assigned this Oct 10, 2022
@teallarson teallarson mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teallarson teallarson

Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪟 🧹 Remove connection and mode prop drilling on connection view/edit pages airbytehq/airbyte
4 participants
@edmundito @krishnaglick @teallarson @octavia-squidington-iii