Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Table UI component to react-table v8 #17941

Closed
timroes opened this issue Oct 13, 2022 · 4 comments · Fixed by #21109
Closed

Migrate Table UI component to react-table v8 #17941

timroes opened this issue Oct 13, 2022 · 4 comments · Fixed by #21109
Assignees
@YatsukBogdan1
Labels
area/frontend Related to the Airbyte webapp team/platform-move technical-debt issues to fix code smell ui/components
Milestone
2023-Q1 Platform ...

Comments

@timroes
Copy link
Collaborator

timroes commented Oct 13, 2022 •
edited
Loading

The Table component we're having has pretty broken types at the moment. It does not know about any cell.value type (they are all any), also there are a lot of generic types from react-table used which never gets a generic parameter passed in and defaulting to any.

The types of this component should get a complete cleanup, since it's at the moment very dangerous to change anything around it, since the types are not giving much type-safteyness.
@timroes timroes added technical-debt issues to fix code smell team/platform-move area/frontend Related to the Airbyte webapp ui/components labels Oct 13, 2022
@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@andyjih
Copy link
Contributor

andyjih commented Nov 17, 2022

@tealjulia @edmundito @dizel852 is the work we're doing on the new Connection table handling this topic?

@edmundito
Copy link
Contributor

@andyjih This is for the standard table component we use in other pages:
https://63053d1047904393cf8d8faa-juyiyqrszv.chromatic.com/?path=/story/ui-table--primary

@edmundito edmundito changed the title Rewrite types of Table component Migrate Table UI component to react-table v8 Nov 29, 2022
@edmundito
Copy link
Contributor

Work on new react-table v8 was started on #19219

@YatsukBogdan1 YatsukBogdan1 self-assigned this Jan 3, 2023
@YatsukBogdan1 YatsukBogdan1 mentioned this issue Jan 6, 2023
Merged
@edmundito edmundito mentioned this issue Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YatsukBogdan1 YatsukBogdan1

Labels
area/frontend Related to the Airbyte webapp team/platform-move technical-debt issues to fix code smell ui/components
Projects
None yet
Milestone
2023-Q1 Platform Move Frontend
Development

Successfully merging a pull request may close this issue.

🪟 🔧 UI Table migration to v8 airbytehq/airbyte
5 participants
@edmundito @andyjih @timroes @YatsukBogdan1 @octavia-squidington-iv