-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🎨 New stream details panel #19219
🪟 🎨 New stream details panel #19219
Conversation
create the first version of table powered by current implementation of react-table;
- use css modules instead of styled cmp - extracted base table styles - remove props used just for styling(customPadding, light, etc.) - no typings
...te-webapp/src/components/connection/CatalogTree/next/StreamFieldsTable/StreamFieldsTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Left a few comments.
One important piece that isn't supported here is scrolling in a long fields list (try PokeAPI).
airbyte-webapp/src/components/connection/CatalogTree/next/NextTable/NextTable.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/components/connection/CatalogTree/next/NextTable/NextTable.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/components/connection/CatalogTree/next/StreamDetailsPanel.tsx
Show resolved
Hide resolved
...p/src/components/connection/CatalogTree/next/StreamFieldsTable/StreamFieldsTable.module.scss
Outdated
Show resolved
Hide resolved
...p/src/components/connection/CatalogTree/next/StreamFieldsTable/StreamFieldsTable.module.scss
Outdated
Show resolved
Hide resolved
...te-webapp/src/components/connection/CatalogTree/next/StreamFieldsTable/StreamFieldsTable.tsx
Outdated
Show resolved
Hide resolved
...app/src/components/connection/CatalogTree/next/StreamFieldsTable/StreamFieldsTableHeader.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # airbyte-webapp/src/components/connection/CatalogTree/next/StreamConnectionHeader.module.scss
Fixes and updates:
Regarding the empty Cursor and PK columns:
Also, regarding case when we have cursor defined(and can't change it): Since we do not have a style for |
airbyte-webapp/src/components/connection/CatalogTree/next/StreamDetailsPanel.tsx
Show resolved
Hide resolved
...pp/src/components/connection/CatalogTree/next/StreamFieldsTable/ConnectorHeaderGroupIcon.tsx
Outdated
Show resolved
Hide resolved
...te-webapp/src/components/connection/CatalogTree/next/StreamFieldsTable/StreamFieldsTable.tsx
Outdated
Show resolved
Hide resolved
...onnection/CatalogTree/next/StreamDetailsPanel/StreamFieldsTable/ConnectorHeaderGroupIcon.tsx
Outdated
Show resolved
Hide resolved
...nents/connection/CatalogTree/next/StreamDetailsPanel/StreamPanelHeader/StreamPanelHeader.tsx
Outdated
Show resolved
Hide resolved
...nents/connection/CatalogTree/next/StreamDetailsPanel/StreamFieldsTable/StreamFieldsTable.tsx
Outdated
Show resolved
Hide resolved
...nents/connection/CatalogTree/next/StreamDetailsPanel/StreamFieldsTable/StreamFieldsTable.tsx
Outdated
Show resolved
Hide resolved
@edmundito regarding explicitly importing React package: Actually, we don't need to do it anymore from React v17. |
fix relative path
# Conflicts: # airbyte-webapp/package-lock.json
fix items alignment in flex container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a light pass over the code and tried it out locally, things looking good to me.
I would definitely defer to Edmundo for final approval.
All comments are fixed. Got approvals from other reviewers.
What
Resolves #18242
How
Adds new Stream Details Panel
Design:
https://www.figma.com/file/liLQhcbpVHiEDW18kiXQe3/01_03_CONNECTIONS?node-id=2376%3A52243
Proto:
https://www.figma.com/proto/liLQhcbpVHiEDW18kiXQe3/01_03_CONNECTIONS?page-id=972%3A36208&node-id=972%3A36212&viewport=446%2C338%2C0.09&scaling=min-zoom&starting-point-node-id=972%3A36212
Reading order
Since our current implementation of
<Table/>
(link) is pretty hard to reuse(styled-components) and extend in new components, we've made a decision(on daily sync) to create a new one. This also finally gives us the ability to fix typings and existing errors in the future without breaking existing tables.next/StreamFieldsTable/StreamFieldsTableHeader.tsx
- actually, we don't need it anymore, since the "streams flow header" become a part of the actual header(thanks to column grouping in react-table link). I've not removed it since I saw it also uses in other PR ./next/NextTable/NextTable.module.scss
- I've tried to extract the "base" styles that we use in the<Table />
component. Props likelight, highlighted, customPadding, customWidth
were not migrated to the new component, since they mostly were used to style the table, and now we can do it in another way