Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving logging interface for workers #2175

Closed
jrhizor opened this issue Feb 23, 2021 · 3 comments
Closed

improving logging interface for workers #2175

jrhizor opened this issue Feb 23, 2021 · 3 comments

Comments

@jrhizor
Copy link
Contributor

jrhizor commented Feb 23, 2021

  1. Separate the logging interface for workers to have a stored mapping of job id to log output path instead of handling MDCs in different locations on the fly.
  2. Ensure all the logic for constructing and running a worker is captured. The construction of integration launchers, for example, should be contained in the worker's log file.

┆Issue is synchronized with this Asana task by Unito

@michel-tricot
Copy link
Contributor

not sure I understand #1. Just want to make sure we don't go in the direction of not using a normal logger.

@jrhizor
Copy link
Contributor Author

jrhizor commented Feb 23, 2021

This isn't changing the use of Logger to anything else. It's about changing what is between setting the MDC and clearing the MDC.

@cgardens
Copy link
Contributor

cgardens commented Oct 6, 2022

closed as stale

@cgardens cgardens closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants