Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Scheduler with a Workflow Engine #1523

Closed
cgardens opened this issue Jan 5, 2021 · 3 comments
Closed

Replace Scheduler with a Workflow Engine #1523

cgardens opened this issue Jan 5, 2021 · 3 comments
Assignees
Labels
temporal type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

cgardens commented Jan 5, 2021

Tell us about the problem you're trying to solve

  • We are rewriting features that exist in any good workflow engine. This is bad because it is slowing us down or making us make trade offs on features in the scheduler that we shouldn't have to make.
  • Existing issue: We want to be able to gracefully cancel a running job. This opens up the ability to greatly simplify the flow for upgrading airbyte versions. But we're gated on writing this feature which would exist in most workflow engines.
  • Existing issue: If airflow is kill -9'ed while a job is running it is unclear that it will recover gracefully when it is started back up. That's because our state machine doesn't have anyway of resolving a job that is in state RUNNING but isn't actually running. We can add code to handle this case, but again we are re writing functionality that is done in any workflow engine.

Describe the solution you’d like

  • I think airflow is the default choice here, but I'm not picky if there's a good case for some other workflow engine (e.g. cadence).
  • tbd list full feature set we are looking for.
@cgardens cgardens added type/enhancement New feature or request priority/medium Medium priority labels Jan 5, 2021
@cgardens cgardens changed the title Replace Scheduler with a Workflow Enginer Replace Scheduler with a Workflow Engine Jan 5, 2021
@michel-tricot michel-tricot changed the title Replace Scheduler with a Workflow Engine Replace Scheduler with a Workflow Engin Jan 5, 2021
@jrhizor jrhizor changed the title Replace Scheduler with a Workflow Engin Replace Scheduler with a Workflow Engine Jan 5, 2021
@cgardens
Copy link
Contributor Author

Goal for this week is a tech spec.

@cgardens cgardens added this to the 2021/01/29 (post launch) milestone Jan 25, 2021
@cgardens cgardens removed the priority/medium Medium priority label Jan 25, 2021
@jrhizor
Copy link
Contributor

jrhizor commented Feb 20, 2021

Planning on working on this over the weekend. Want to finish this out.

@cgardens cgardens modified the milestones: 2021-02-19, 2021-02-26 Feb 23, 2021
@jrhizor jrhizor removed this from the 2021-02-26 milestone Feb 23, 2021
@jrhizor jrhizor closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
temporal type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants