Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JobSubmitter/JobCreator/JobPersistence interface #2179

Closed
jrhizor opened this issue Feb 23, 2021 · 1 comment
Closed

Refactor JobSubmitter/JobCreator/JobPersistence interface #2179

jrhizor opened this issue Feb 23, 2021 · 1 comment
Labels
temporal type/enhancement New feature or request

Comments

@jrhizor
Copy link
Contributor

jrhizor commented Feb 23, 2021 •
edited by sync-by-unito bot
Loading

  • It’s fine for the JobPersistence to be used to update the state of the jobs, but allowing other entities that aren’t limited to just within the actual job runs makes it incredibly difficult to have an external framework manage the state of the job runs automatically.
  • The goal of this step is to only allow job-internal code to modify state in JobPersistence with the exception of the JobRetrier

┆Issue is synchronized with this Asana task by Unito
@jrhizor jrhizor added type/enhancement New feature or request temporal labels Feb 23, 2021
@jrhizor jrhizor mentioned this issue Feb 23, 2021
Closed
@cgardens cgardens assigned cgardens and unassigned cgardens Feb 26, 2021
@cgardens
Copy link
Contributor

not relevant anymore with scheduler 2 project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
temporal type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrhizor @cgardens