Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Jira: change wording for description of array fields #10835

Merged
merged 5 commits into from
May 4, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Mar 3, 2022

This description for the array fields can be misleading for users:

Comma-separated list of Jira project keys to replicate data for. (e.g. PROJ1, PROJ2)

Some are filling this field like this:
Screen Shot 2022-03-03 at 17 15 58
But it should be filled like this:
Screen Shot 2022-03-03 at 17 16 41

I received the feedback from this slack conversation:

Hi! Got the exact same issue a while ago. It turned out that I was misled by the text in the config : “Projects - Comma-separated list of Jira project keys to replicate data for. (e.g. PROJ1, PROJ2)“.
What works is entering the keys of the projects, and validating them one by one, something like this. With commas, it fails

I'm suggesting removing "comma-separated" from the description, but feel free to suggest better wording!

@github-actions github-actions bot added the area/connectors Connector related issues label Mar 3, 2022
@alafanechere
Copy link
Contributor Author

@misteryeo I'm curious if we have a common way of describing array fields on other connectors and if it is a kind of feedback you already got.

@alafanechere alafanechere changed the title Source Jira: change wording for description of project field Source Jira: change wording for description of array fields Mar 3, 2022
@alafanechere alafanechere temporarily deployed to more-secrets March 3, 2022 16:26 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets March 3, 2022 16:27 Inactive
@alafanechere alafanechere added connectors/source/jira type/enhancement New feature or request area/documentation Improvements or additions to documentation labels Mar 3, 2022
@misteryeo
Copy link
Contributor

@alafanechere haven't seen this feedback come up but curious to dig into the behavior here.

How does the field recognize that you're entering different items in the array? What triggers this separation - is it by pressing the space bar or by separating the different items using a comma?

@misteryeo
Copy link
Contributor

I just came across this in our Google Ads source and I'm not seeing the UI resolve the different items separated by commas:
Airbyte  Sources  Google Ads 2022-03-04 at 1 27 43 PM

@marcosmarxm
Copy link
Member

I just came across this in our Google Ads source and I'm not seeing the UI resolve the different items separated by commas: Airbyte Sources Google Ads 2022-03-04 at 1 27 43 PM

This is because this field is a string and the connector code map to a list.

"customer_id": {
"title": "Customer ID(s)",
"type": "string",
"description": "Comma separated list of (client) customer IDs. Each customer ID must be specified as a 10-digit number without dashes. More instruction on how to find this value in our <a href=\"https://docs.airbyte.com/integrations/sources/google-ads#setup-guide\">docs</a>. Metrics streams like AdGroupAdReport cannot be requested for a manager account.",
"pattern": "^[0-9]{10}(,[0-9]{10})*$",
"examples": ["6783948572,5839201945"],
"order": 1

Jira connector use the array data type in the specification

"additional_fields": {
"type": "array",
"title": "Additional Fields",
"items": {
"type": "string"
},
"description": "Comma-separated list of additional fields to include in replicating issues.",
"examples": ["Field A", "Field B"]
},

@marcosmarxm
Copy link
Member

@alafanechere haven't seen this feedback come up but curious to dig into the behavior here.

How does the field recognize that you're entering different items in the array? What triggers this separation - is it by pressing the space bar or by separating the different items using a comma?

pressing enter, there is an issue complaining you cann't only paste the value from the clipboard.

@misteryeo
Copy link
Contributor

@timroes curious to understand your thoughts here. I feel like the UI behavior is not ideal.

There's another issue raised here about the similar challenge: #8630.

My sense is that the expected behavior here should be:

  1. The item becomes defined when I use a 'comma' not a 'space'.
  2. If I copy and paste a list of comma separated fields here, the commas automatically separate each individual item.

Does that resonate? I think this is a UI challenge rather than a wording challenge.

@timroes
Copy link
Collaborator

timroes commented Mar 9, 2022

Usually this input fields will require a press of Enter to create an "item" in the list. There is also no hint for that in the UI while typing and no way of pasting a list already in, that will automatically be separated. Usually an input like this should offer pasting in something that will automatically be separated into tokens by a separator character. I'd say we should still improve the wording here to remove the comma-separated, but should also try to improve this UI control to allow for pasting values as well as giving better guidance. I've created #10985 to track this.

@misteryeo
Copy link
Contributor

Issue was linked to Harvestr Discovery: Array Fields

@alafanechere alafanechere self-assigned this Apr 11, 2022
@alafanechere
Copy link
Contributor Author

alafanechere commented May 4, 2022

/publish connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2268678988
❌ Failed to publish connectors/source-jira
❌ Couldn't auto-bump version for connectors/source-jira

@alafanechere
Copy link
Contributor Author

alafanechere commented May 4, 2022

/publish connector=connectors/source-jira run-tests=false

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2268754863
🚀 Successfully published connectors/source-jira
🚀 Auto-bumped version for connectors/source-jira
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/2268754863

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 4, 2022 09:09 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 4, 2022 09:09 Inactive
@alafanechere alafanechere merged commit 8ca229b into master May 4, 2022
@alafanechere alafanechere deleted the augustin/source-jira/change-projects-wording branch May 4, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants