-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Jira: change wording for description of array fields #10835
Source Jira: change wording for description of array fields #10835
Conversation
@misteryeo I'm curious if we have a common way of describing array fields on other connectors and if it is a kind of feedback you already got. |
@alafanechere haven't seen this feedback come up but curious to dig into the behavior here. How does the field recognize that you're entering different items in the array? What triggers this separation - is it by pressing the space bar or by separating the different items using a comma? |
This is because this field is a string and the connector code map to a list. airbyte/airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json Lines 52 to 58 in 754452c
Jira connector use the array data type in the specification
|
pressing enter, there is an issue complaining you cann't only paste the value from the clipboard. |
@timroes curious to understand your thoughts here. I feel like the UI behavior is not ideal. There's another issue raised here about the similar challenge: #8630. My sense is that the expected behavior here should be:
Does that resonate? I think this is a UI challenge rather than a wording challenge. |
Usually this input fields will require a press of Enter to create an "item" in the list. There is also no hint for that in the UI while typing and no way of pasting a list already in, that will automatically be separated. Usually an input like this should offer pasting in something that will automatically be separated into tokens by a separator character. I'd say we should still improve the wording here to remove the |
Issue was linked to Harvestr Discovery: Array Fields |
/publish connector=connectors/source-jira
|
/publish connector=connectors/source-jira run-tests=false
|
This description for the array fields can be misleading for users:
Some are filling this field like this:
But it should be filled like this:
I received the feedback from this slack conversation:
I'm suggesting removing "comma-separated" from the description, but feel free to suggest better wording!