Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source and Destination MSSql: add jdbc_url_params in connection config #11010

Merged
merged 9 commits into from
Mar 29, 2022

Conversation

Danucas
Copy link
Contributor

@Danucas Danucas commented Mar 10, 2022

What

Solves Destination MSSQL: custom JDBC parameters #10718 as well as Source MSSQL

How

By taking jdbc_url_params defined in specs, then adding it to configBuilder as connection_properties according to AbstractJdbcSource.createDatabase() which parses the jdbcConfig using this key to create a JdbcDatabase instance

Recommended reading order

  1. MSSQLDestination.java
  2. [MssqlSource.java

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Now JDBC URL PARAMS is enabled in MSSQL Source and Destination

Captura de Pantalla 2022-03-09 a la(s) 6 56 05 p  m

Captura de Pantalla 2022-03-09 a la(s) 6 58 43 p  m

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Mar 10, 2022
@marcosmarxm
Copy link
Member

Thanks for the contribution @Danucas

@Danucas
Copy link
Contributor Author

Danucas commented Mar 10, 2022

I'm still solving the tests, for some reason, it says airbyte/source-mssql image not found. I'll ask for illumination at the slack channel

@marcosmarxm
Copy link
Member

Let me now if you need help here

@Danucas
Copy link
Contributor Author

Danucas commented Mar 25, 2022

Is This PR missing just the workflow approval?

@marcosmarxm
Copy link
Member

Is This PR missing just the workflow approval?
@Danucas I tested locally and its working. We got a problem with our /publish command to release the new version.

@marcosmarxm marcosmarxm temporarily deployed to more-secrets March 29, 2022 22:15 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets March 29, 2022 22:15 Inactive
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Danucas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants