-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source and Destination MSSql: add jdbc_url_params in connection config #11010
Conversation
Thanks for the contribution @Danucas |
I'm still solving the tests, for some reason, it says airbyte/source-mssql image not found. I'll ask for illumination at the slack channel |
Let me now if you need help here |
Is This PR missing just the workflow approval? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Danucas
What
Solves Destination MSSQL: custom JDBC parameters #10718 as well as Source MSSQL
How
By taking
jdbc_url_params
defined in specs, then adding it to configBuilder asconnection_properties
according to AbstractJdbcSource.createDatabase() which parses the jdbcConfig using this key to create a JdbcDatabase instanceRecommended reading order
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Now
JDBC URL PARAMS
is enabled in MSSQL Source and DestinationPre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here