Publish PR 10513: amazon ads add timeout params in spec #11480

marcosmarxm · 2022-03-28T20:05:43Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…te into marcos/test-pr-10513

marcosmarxm · 2022-03-28T20:06:22Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2054628815
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2054628815
🐛 https://gradle.com/s/ir725duml7oga

codecov · 2022-03-28T20:13:47Z

Codecov Report

❗ No coverage uploaded for pull request base (master@bf66d32). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11480   +/-   ##
=========================================
  Coverage          ?   98.92%           
=========================================
  Files             ?       22           
  Lines             ?      651           
  Branches          ?        0           
=========================================
  Hits              ?      644           
  Misses            ?        7           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf66d32...a648499. Read the comment docs.

marcosmarxm · 2022-03-28T23:36:10Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2055489530
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2055489530
🐛 https://gradle.com/s/cbamgyofsb6ey

marcosmarxm · 2022-03-29T22:16:48Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2061419053
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2061419053
🐛 https://gradle.com/s/niztqwbkqvy6y
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 1 failed, 21 passed, 1 skipped in 16.84s ===================

marcosmarxm · 2022-03-29T23:59:27Z

/test connector=connectors/source-amazon-ads

marcosmarxm · 2022-03-30T16:22:19Z

/test connector=connectors/source-amazon-ads

marcosmarxm · 2022-03-30T16:46:55Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2066200254
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2066200254
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          16      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/common.py                                  78      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            25      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          199      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               657      7    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 22 passed, 1 skipped in 19.20s ========================

marcosmarxm · 2022-03-30T17:38:05Z

/publish connector=connectors/source-amazon-ads

marcosmarxm · 2022-03-30T17:43:34Z

/publish connector=connectors/source-amazon-ads

marcosmarxm · 2022-03-30T19:51:20Z

/publish connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2067072501
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2067072501

aakashkumarmaple and others added 11 commits February 21, 2022 23:20

Changes for increasing timeout for long taking report generation

a95a8a2

moidifing amazon-ads.md for pr 10513

6380e8d

Deleting STANDARD_SOURCE_DEFINATION file as mentioned in review comment

93fbaf0

Adding spec file for taking timeout by user

9c12c9a

Removing unused libraries

4c44744

Spec file changes and report_changes for max_retries

81aad1f

Bakoff Fixes for taking retries values and timeout values from User

97e8d81

Review Comment Fixes

4003329

spec file adding examples

7ca7681

Merge branch 'amazon_ads_bugfix' of github.com:aakashkumarmaple/airby…

13032e9

…te into marcos/test-pr-10513

correct spec description

c84a0ac

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 28, 2022

marcosmarxm temporarily deployed to more-secrets March 28, 2022 20:07 Inactive

marcosmarxm temporarily deployed to more-secrets March 28, 2022 20:08 Inactive

marcosmarxm added 2 commits March 28, 2022 19:56

run black

505d1d1

remove tests

48b350e

marcosmarxm temporarily deployed to more-secrets March 28, 2022 23:38 Inactive

Merge branch 'master' into marcos/test-pr-10513

3e6ad62

marcosmarxm temporarily deployed to more-secrets March 29, 2022 22:18 Inactive

correct spec test

ac37fd6

Merge branch 'master' into marcos/test-pr-10513

bf6c711

marcosmarxm temporarily deployed to more-secrets March 30, 2022 16:51 Inactive

add eof

b3fb0ab

Merge branch 'master' into marcos/test-pr-10513

a648499

marcosmarxm closed this Mar 30, 2022

marcosmarxm deleted the marcos/test-pr-10513 branch March 30, 2022 21:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish PR 10513: amazon ads add timeout params in spec #11480

Publish PR 10513: amazon ads add timeout params in spec #11480

marcosmarxm commented Mar 28, 2022

marcosmarxm commented Mar 28, 2022 •

edited by github-actions bot

Loading

codecov bot commented Mar 28, 2022 •

edited

Loading

marcosmarxm commented Mar 28, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 29, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 29, 2022

marcosmarxm commented Mar 30, 2022

marcosmarxm commented Mar 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 30, 2022

marcosmarxm commented Mar 30, 2022

marcosmarxm commented Mar 30, 2022 •

edited by github-actions bot

Loading

Publish PR 10513: amazon ads add timeout params in spec #11480

Publish PR 10513: amazon ads add timeout params in spec #11480

Conversation

marcosmarxm commented Mar 28, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Mar 28, 2022 • edited by github-actions bot Loading

codecov bot commented Mar 28, 2022 • edited Loading

Codecov Report

marcosmarxm commented Mar 28, 2022 • edited by github-actions bot Loading

marcosmarxm commented Mar 29, 2022 • edited by github-actions bot Loading

marcosmarxm commented Mar 29, 2022

marcosmarxm commented Mar 30, 2022

marcosmarxm commented Mar 30, 2022 • edited by github-actions bot Loading

marcosmarxm commented Mar 30, 2022

marcosmarxm commented Mar 30, 2022

marcosmarxm commented Mar 30, 2022 • edited by github-actions bot Loading

marcosmarxm commented Mar 28, 2022 •

edited by github-actions bot

Loading

codecov bot commented Mar 28, 2022 •

edited

Loading

marcosmarxm commented Mar 28, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 29, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 30, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Mar 30, 2022 •

edited by github-actions bot

Loading