🐛 Fix bucket path for destination s3 #11496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheDuong
changed the title
Phlair
approved these changes
Mar 29, 2022
| : S3DestinationConstants.DEFAULT_PATH_FORMAT; | ||
| final String outputBucketPath = storageOperations.getBucketObjectPath(outputNamespace, streamName, SYNC_DATETIME, customOutputFormat); | ||
| final String bucketPath = config.get(BUCKET_PATH_FIELD).asText(); | ||
| final String customOutputFormat = String.join("/", |
There was a problem hiding this comment.
does customOutputFormat still make sense as the name here when we're including bucketPath?
There was a problem hiding this comment.
you can still customize the end part of the bucket path
it just always starts with the bucketPath now
github-actions
bot
added
the
area/documentation
|
/publish connector=connectors/destination-s3
|
This was referenced Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #11482
How
Use s3_bucket_path when constructing the object path
Recommended reading order
x.javay.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
/test connector=connectors/<name>command is passing/publishcommand described here