add ability to launch all integration/standard tests from slash commands #1169
Conversation
|
/source-exchangeratesapi-singer |
|
/source-exchangeratesapi-singer |
|
/source-exchangeratesapi-singer |
|
/source-exchangeratesapi-singer ref=jrhizor/add-other-builds |
|
/source-exchangeratesapi-singer |
1 similar comment
|
/source-exchangeratesapi-singer |
|
/source-exchangeratesapi-singer |
2 similar comments
|
/source-exchangeratesapi-singer |
|
/source-exchangeratesapi-singer |
…for image existing
jrhizor
changed the title
|
This is ready for review. I'll probably have to make some more dependency fixes to get the |
| all_standard_python_tests=$(./gradlew standardSourceTestPython --dry-run | grep 'standardSourceTestPython SKIPPED' | cut -d: -f 4) | ||
|
|
||
| if [[ "$connector" == "all" ]] ; then | ||
| echo "Running: ./gradlew --no-daemon --scan integrationTest standardSourceTestPython" |
There was a problem hiding this comment.
| echo "Running: ./gradlew --no-daemon --scan integrationTest standardSourceTestPython" | |
| cmd="./gradlew --no-daemon --scan integrationTest standardSourceTestPython" | |
| echo "Running: $cmd" | |
| $cmd |
There was a problem hiding this comment.
Just $cmd doesn't work, and we'd need to add evals.
# jrhizor in ~/code/airbyte on git:jrhizor/add-other-builds ● [15:01:23]
→ cmd="echo hi"
# jrhizor in ~/code/airbyte on git:jrhizor/add-other-builds ● [15:03:10]
→ $cmd
zsh: command not found: echo hi
Since this is temporary anyways, going to just merge as is and improve later.
|
|
||
| if [[ "$connector" == "all" ]] ; then | ||
| echo "Running: ./gradlew --no-daemon --scan integrationTest standardSourceTestPython" | ||
| ./gradlew --no-daemon --scan integrationTest standardSourceTestPython |
There was a problem hiding this comment.
| ./gradlew --no-daemon --scan integrationTest standardSourceTestPython |
| echo "Running: ./gradlew --no-daemon --scan integrationTest standardSourceTestPython" | ||
| ./gradlew --no-daemon --scan integrationTest standardSourceTestPython | ||
| else | ||
| selected_integration_test=$(echo "$all_integration_tests" | grep "^$connector$" || echo "") |
There was a problem hiding this comment.
not blocking for this PR, but should this selection logic live in a gradle task where we just say "integrationTest" and it figures out whether it's standard python or anything else? That way it can be re-used by any other tools, and is more accessible for anyone new to the repo since it's all wrapped in a gradle task
There was a problem hiding this comment.
Agreed. It feels like integrationTest is the right umbrella task, but we'd need to switch that to javaIntegrationTest or something first to put both under it.
Allows any connector to be tested from PRs with
/test connector=source-shopify-singer(or/test connector=source-shopify-singer ref=COMMITif you want to override the branch/commit).These won't start working until after this is pushed, because workflow dispatch commands need the setup for the slash command to exist on
master- it's basically a limitation of Github Actions.We can see an example of it running in this branch until the commit to remove
jrhizor/add-other-builds.