🐛 Destination Redshift: fix switching mode #12085

yurii-bidiuk · 2022-04-15T20:08:05Z

What

How

Add an additional check for the empty string to isCopy(..) method

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

alexandr-shegeda

LGTM. we can proceed with publishing and merging without airbyte review

yurii-bidiuk · 2022-04-20T08:32:56Z

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2194528981
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2194528981
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       168     31    82%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           33      7    79%
normalization/transform_catalog/catalog_processor.py                                                                              143     77    46%
normalization/transform_catalog/transform.py                                                                                       45     26    42%
normalization/transform_catalog/stream_processor.py                                                                               524    337    36%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1403    520    63%

yurii-bidiuk · 2022-04-20T11:56:43Z

/publish connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2195522298
❌ Failed to publish connectors/destination-redshift
❌ Couldn't auto-bump version for connectors/destination-redshift

yurii-bidiuk · 2022-04-20T12:08:43Z

/publish connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2195585726
❌ Failed to publish connectors/destination-redshift
❌ Couldn't auto-bump version for connectors/destination-redshift

yurii-bidiuk · 2022-04-20T12:24:00Z

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2195663669
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2195663669
Python tests coverage:

Name                                                                                                                            Stmts   Miss  Cover
---------------------------------------------------------------------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                                                                                          2      0   100%
normalization/transform_catalog/reserved_keywords.py                                                                               13      0   100%
normalization/transform_catalog/__init__.py                                                                                         2      0   100%
normalization/destination_type.py                                                                                                  13      0   100%
normalization/__init__.py                                                                                                           4      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py     124      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/__init__.py               1      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/__init__.py                      2      0   100%
normalization/transform_catalog/destination_name_transformer.py                                                                   155      8    95%
normalization/transform_config/transform.py                                                                                       159     31    81%
normalization/transform_catalog/table_name_registry.py                                                                            174     34    80%
normalization/transform_catalog/utils.py                                                                                           34      7    79%
normalization/transform_catalog/dbt_macro.py                                                                                       22      7    68%
normalization/transform_catalog/catalog_processor.py                                                                              147     80    46%
normalization/transform_catalog/transform.py                                                                                       61     38    38%
normalization/transform_catalog/stream_processor.py                                                                               534    345    35%
---------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                            1447    550    62%

yurii-bidiuk · 2022-04-20T12:55:19Z

/publish connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2195816662
🚀 Successfully published connectors/destination-redshift
🚀 Auto-bumped version for connectors/destination-redshift
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/2195816662

* fix switching mode for redshift * bump version * format code * update spec

github-actions bot added the area/connectors Connector related issues label Apr 15, 2022

yurii-bidiuk force-pushed the bidiuk/10940-fix-edit-s3-destination branch 2 times, most recently from a6a4d1f to 2fe9d94 Compare April 15, 2022 21:25

yurii-bidiuk requested a review from alexandr-shegeda April 15, 2022 21:26

alexandr-shegeda approved these changes Apr 18, 2022

View reviewed changes

alexandr-shegeda marked this pull request as ready for review April 18, 2022 10:02

yurii-bidiuk force-pushed the bidiuk/10940-fix-edit-s3-destination branch from 2fe9d94 to 801fab7 Compare April 20, 2022 08:32

github-actions bot referenced this pull request Apr 20, 2022

fix switching mode for redshift

801fab7

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 20, 2022

yurii-bidiuk temporarily deployed to more-secrets April 20, 2022 11:58 Inactive

yurii-bidiuk force-pushed the bidiuk/10940-fix-edit-s3-destination branch 2 times, most recently from 26bbb19 to a938c64 Compare April 20, 2022 12:07

yurii-bidiuk added 2 commits April 20, 2022 15:21

fix switching mode for redshift

4928193

bump version

b40811d

yurii-bidiuk force-pushed the bidiuk/10940-fix-edit-s3-destination branch from a938c64 to b40811d Compare April 20, 2022 12:23

yurii-bidiuk temporarily deployed to more-secrets April 20, 2022 12:25 Inactive

format code

21339ed

github-actions bot added the normalization label Apr 20, 2022

yurii-bidiuk temporarily deployed to more-secrets April 20, 2022 12:56 Inactive

octavia-squidington-iii temporarily deployed to more-secrets April 20, 2022 13:20 Inactive

update spec

9906998

yurii-bidiuk force-pushed the bidiuk/10940-fix-edit-s3-destination branch from a8e2bfd to 9906998 Compare April 20, 2022 13:38

yurii-bidiuk temporarily deployed to more-secrets April 20, 2022 13:40 Inactive

yurii-bidiuk merged commit 785bcc4 into master Apr 20, 2022

yurii-bidiuk deleted the bidiuk/10940-fix-edit-s3-destination branch April 20, 2022 13:57

octavia-squidington-iii mentioned this pull request Apr 20, 2022

Bump Airbyte version from 0.36.1-alpha to 0.36.2-alpha #12194

Closed

yurii-bidiuk mentioned this pull request Apr 21, 2022

Revert formatting for test_pokemon_super.sql #12234

Merged

38 tasks

octavia-squidington-iii mentioned this pull request Apr 21, 2022

Bump Airbyte version from 0.36.1-alpha to 0.36.2-alpha #12258

Merged

suhomud pushed a commit that referenced this pull request May 23, 2022

🐛 Destination Redshift: fix switching mode (#12085)

7812eb2

* fix switching mode for redshift * bump version * format code * update spec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Destination Redshift: fix switching mode #12085

🐛 Destination Redshift: fix switching mode #12085

yurii-bidiuk commented Apr 15, 2022

alexandr-shegeda left a comment

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

🐛 Destination Redshift: fix switching mode #12085

🐛 Destination Redshift: fix switching mode #12085

Conversation

yurii-bidiuk commented Apr 15, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

alexandr-shegeda left a comment

Choose a reason for hiding this comment

yurii-bidiuk commented Apr 20, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 20, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 20, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 20, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 20, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented Apr 20, 2022 •

edited by github-actions bot

Loading