Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Analytics: doc and specs minor fixes #12150

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Source Google Analytics: doc and specs minor fixes #12150

merged 3 commits into from
Apr 20, 2022

Conversation

davydov-d
Copy link
Collaborator

What

Minor changes to documentation and spec.json

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b24a4be). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12150   +/-   ##
=========================================
  Coverage          ?   91.78%           
=========================================
  Files             ?        2           
  Lines             ?      280           
  Branches          ?        0           
=========================================
  Hits              ?      257           
  Misses            ?       23           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24a4be...94d7445. Read the comment docs.

@midavadim
Copy link
Contributor

can be released without airbyte review

@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 20, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2195041658
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2195041658
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%
Name                                     Stmts   Miss  Cover
------------------------------------------------------------
source_google_analytics_v4/__init__.py       2      0   100%
source_google_analytics_v4/source.py       278     23    92%
------------------------------------------------------------
TOTAL                                      280     23    92%

@davydov-d
Copy link
Collaborator Author

davydov-d commented Apr 20, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2195105053
🚀 Successfully published connectors/source-google-analytics-v4
🚀 Auto-bumped version for connectors/source-google-analytics-v4
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2195105053

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 20, 2022 10:41 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 20, 2022 10:41 Inactive
@davydov-d davydov-d merged commit a70d28d into master Apr 20, 2022
@davydov-d davydov-d deleted the ddavydov/10938-ga-to-beta-fix-doc branch April 20, 2022 11:10
This was referenced Apr 20, 2022
Closed
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@davydov-d @octavia-squidington-iii @suhomud
Source Google Analytics: doc and specs minor fixes (#12150)
4b72d6b 
* #10938 doc and specs minor fixes

* #10938 add changelog item

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubberr grubberr grubberr approved these changes

@annalvova05 annalvova05 annalvova05 approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davydov-d @midavadim @grubberr @annalvova05 @octavia-squidington-iii