Destination-Postgres: updated postgres.md documentation as per BETA template #12279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
…ed-to-beta # Conflicts: # docs/integrations/destinations/postgres.md
etsybaev
changed the title
grishick
suggested changes
Apr 28, 2022
|
|
||
| #### Requirements | ||
| You should now have all the requirements needed to configure Postgres as a destination in the UI. |
There was a problem hiding this comment.
You should now have all the requirements needed to configure Postgres as a destination in the UI.
I think this sentence is redundant and should be removed
| * **Port** - The port number the server is listening on. Defaults to the PostgreSQL™ standard port number (5432). | ||
| * **Username** | ||
| * **Password** | ||
| * **Default Schema Name** - Specify the schema (or several schema separated by commas) to be set in the search-path. This schema will be used to resolve unqualified object names used in statements over this connection. |
There was a problem hiding this comment.
nit:
- several schemas
- These schemas will be used to resolve unqualified object names
usedin statements executed over this connection
| * Subsequent characters in an identifier or key word can be letters, underscores, digits \(0-9\), or | ||
| dollar signs \($\). | ||
|
|
||
| Note that dollar signs are not allowed in identifiers according to the letter of the SQL standard, |
There was a problem hiding this comment.
according to the letter of the SQL standard
| still applies. | ||
| * Quoting an identifier also makes it case-sensitive, whereas unquoted names are always folded to | ||
| lower case. | ||
| * If you want to write portable applications you are advised to always quote a particular name or |
There was a problem hiding this comment.
Rephrase: In order to make your applications portable and less error-prone, use consistent quoting with each name (either always quote it or never quote it).
| * If you want to write portable applications you are advised to always quote a particular name or | ||
| never quote it. | ||
|
|
||
| Therefore, Airbyte Postgres destination will create tables and schemas using the Unquoted |
|
|
||
| #### Output Schema | ||
|
|
||
| Each stream will be output into its own table in Postgres. Each table will contain 3 columns: |
There was a problem hiding this comment.
Rephrase: Each stream will be mapped to a separate table in Postgres.
grishick
approved these changes
Apr 28, 2022
etsybaev
deleted the
etsybaev/11790-destination-postgres-prepared-to-beta
branch
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
…emplate (#12279) * Updated postgres.md documentation as per BETA template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Documentation didn't correspond to the template
How
Updated documentation for connector
🚨 User Impact 🚨
No users impact
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.