Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Tiktok Marketing - updated specs description #12435

Merged
merged 7 commits into from
May 2, 2022

Conversation

midavadim
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label Apr 28, 2022
@midavadim midavadim linked an issue Apr 28, 2022 that may be closed by this pull request
9 tasks
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Apr 28, 2022
@midavadim midavadim requested a review from grubberr April 28, 2022 14:21
@CLAassistant
Copy link

CLAassistant commented Apr 28, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sherifnada
Copy link
Contributor

@midavadim just a reminder per the slack message sent yesterday, updating spec descriptions is no longer part of the certification process that engineering needs to worry about

@midavadim
Copy link
Contributor Author

midavadim commented May 2, 2022

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2258707070
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2258707070
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_tiktok_marketing/spec.py          65      0   100%
source_tiktok_marketing/source.py        49      0   100%
source_tiktok_marketing/__init__.py       2      0   100%
source_tiktok_marketing/streams.py      316     24    92%
---------------------------------------------------------
TOTAL                                   432     24    94%

@midavadim midavadim temporarily deployed to more-secrets May 2, 2022 15:38 Inactive
@midavadim midavadim temporarily deployed to more-secrets May 2, 2022 15:38 Inactive
@midavadim
Copy link
Contributor Author

midavadim commented May 2, 2022

/publish connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2258881281
🚀 Successfully published connectors/source-tiktok-marketing
🚀 Auto-bumped version for connectors/source-tiktok-marketing
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2258881281

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 2, 2022 16:02 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 2, 2022 16:03 Inactive
@midavadim midavadim merged commit 915573e into master May 2, 2022
@midavadim midavadim deleted the midavadim/11029-fix-spec-description branch May 2, 2022 16:37
@midavadim midavadim temporarily deployed to more-secrets May 2, 2022 16:38 Inactive
@midavadim midavadim temporarily deployed to more-secrets May 2, 2022 16:38 Inactive
suhomud pushed a commit that referenced this pull request May 23, 2022
* updated seed files

* updated change history

* updated docs

* updated connector version

* auto-bump connector version

* updated source specs

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] Source TikTok to Cloud Beta
5 participants