Fix new source / destination test connection success / failure tracking events #12526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nection is being tested and remove from creation
Update new destination actions with useTrackAction hook
github-actions
bot
added
area/frontend
area/platform
edmundito
commented
May 2, 2022
| action: "Select a connector", | ||
| connector_destination_definition: connector?.name, | ||
| trackNewDestinationAction("Select a connector", { | ||
| connector_destination: connector?.name, |
There was a problem hiding this comment.
The PM's spec for these events calls this property connector_destination. Not all destination events are using this (yet) but at least it makes these actions consistent.
edmundito
commented
May 2, 2022
| connector_source_definition: connector?.name, | ||
| connector_source_definition_id: sourceDefinitionId, | ||
| trackNewSourceAction("Select a connector", { | ||
| connector_source: connector?.name, |
There was a problem hiding this comment.
The PM's spec for these events calls this property connector_source. Not all source events are using this (yet) but at least it makes these actions consistent.
edmundito
commented
May 2, 2022
| connector_source_definition_id: sourceDefinitionId, | ||
| trackNewSourceAction("Select a connector", { | ||
| connector_source: connector?.name, | ||
| connector_source_id: sourceDefinitionId, |
There was a problem hiding this comment.
The PM's spec for these events calls this property connector_source_definition_id. However, it's evenly split with both names across the codebase. For now, the name stays this way, but I will create an issue to make this consistent.
… new source actions
krishnaglick
approved these changes
May 3, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
…ng events (#12526) * Consolidate track new action analytics calls into hook * Move new source and destination test tracking to where the actual connection is being tested and remove from creation * Use consistent properties across all track new source actions * Make track action hook more generic and support new destination actions Update new destination actions with useTrackAction hook * Use connector_source_definition_id over connector_source_id for track new source actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, the source and destination connection test was not sending the events on test connection failure. Additionally, some of the properties passed down were inconsistent. This fixes both of those issues.
How
This change does a couple of things:
It moves the test connection tracking events to where the connection is being tested
Prior to this change, the connection was tracking the test connection success or failure events after creating the source or destination. However, if the test connection fails, it would never call create connection and the failure events would not be triggered.
Now all the test connection events happen when the test connection event is called instead.
It creates a hook for tracking that respects the tracking spec
Adds a new hook
useTrackActionwhich respects the spec set for tracking. For this change, the hook is only used for the new source / new destination action events but could be expanded beyond the current use as separate issues. The hook ensures that the correct event name is set and the correct event properties are used.Recommended reading order
Start from the bottom and work your way to the top